WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 35 hours ago

#44125 new defect (bug)

Privacy: Inline docs improvements

Reported by: birgire Owned by:
Milestone: 4.9.7 Priority: normal
Severity: minor Version: 4.9.6
Component: Privacy Keywords: has-patch
Focuses: docs Cc:

Description (last modified by desrosj)

There are some missing inline docs for hooks and some other further adjustments needed.

This is an ongoing ticket for Privacy documentation improvements similar to #42505.

Attachments (3)

44125.diff (4.3 KB) - added by birgire 5 weeks ago.
44125.2.diff (1.0 KB) - added by desrosj 5 weeks ago.
Add new cookies field to the comment_form() docblock.l
44125.3.diff (646 bytes) - added by chetan200891 5 weeks ago.
Added @since for cookies field to the comment_form() docblock.l

Download all attachments as: .zip

Change History (15)

@birgire
5 weeks ago

#1 @birgire
5 weeks ago

  • Keywords has-patch added

44125.diff:

  • Adds missing inline docs for the wp_privacy_personal_data_export_file action.
  • Adds missing filter reference for the filters:
    • wp_privacy_personal_data_exporters
    • wp_privacy_personal_data_erasers
  • Fixes wrong filter reference for the inline docs of the wp_privacy_export_expiration filter.
  • Fixes wrong type for the request ID in the inline docs of the wp_privacy_personal_data_export_file_created action.

#2 @desrosj
5 weeks ago

  • Version changed from trunk to 4.9.6

Marking Privacy change as introduced in 4.9.6.

#3 @desrosj
5 weeks ago

  • Milestone changed from Awaiting Review to 4.9.7

@desrosj
5 weeks ago

Add new cookies field to the comment_form() docblock.l

@chetan200891
5 weeks ago

Added @since for cookies field to the comment_form() docblock.l

#4 @netweb
5 weeks ago

  • Keywords needs-refresh added

Why are there 3 completely different patches for this ticket? They should be combined into a single patch.

#5 @desrosj
5 weeks ago

  • Description modified (diff)
  • Keywords needs-refresh removed

Just updated the ticket to specify it is an ongoing ticket for Privacy documentation improvements. #42505 was what this ticket was meant to replicate.

#6 @SergeyBiryukov
4 weeks ago

In 43303:

Docs: Add missing documentation and duplicate hook references for wp_privacy_personal_data_export_file, wp_privacy_personal_data_exporters, and wp_privacy_personal_data_erasers hooks.

Props birgire.
See #44125.

#7 @SergeyBiryukov
4 weeks ago

In 43304:

Docs: Document the cookies default comment field added in [42772].

Props desrosj, chetan200891.
See #44125.

#8 @SergeyBiryukov
4 weeks ago

In 43305:

Docs: Add missing documentation and duplicate hook references for wp_privacy_personal_data_export_file, wp_privacy_personal_data_exporters, and wp_privacy_personal_data_erasers hooks.

Props birgire.
Merges [43303] to the 4.9 branch.
See #44125.

#9 @SergeyBiryukov
4 weeks ago

In 43306:

Docs: Document the cookies default comment field added in [42772].

Props desrosj, chetan200891.
Merges [43304] to the 4.9 branch.
See #44125.

#10 @desrosj
4 weeks ago

  • Milestone changed from 4.9.7 to 4.9.8

Moving all tickets in 4.9.7 to 4.9.8.

#11 @SergeyBiryukov
4 weeks ago

  • Milestone changed from 4.9.8 to 4.9.7

Moving back to 4.9.7, as the changes here are already backported to the branch.

Keeping the ticket open for now, just in case any more documentation fixes follow up.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


35 hours ago

Note: See TracTickets for help on using tickets.