Setting Privacy Policy page as existing page gives misleading alert

[garrett-eclipse]

Hello,

We have an existing Privacy Policy so using the new tools on 4.9.6 we selected our existing page and clicked 'Use This Page' on the Privacy Settings page. On completion of this action the page reloads with the alert 'Privacy policy page updated successfully. Remember to update your menus!' which made my heart skip a beat thinking the pages content was updated in some way. To avoid this panic and people asking what's been updated on their page maybe this message can be modified to indicate what actually happens, 'Privacy Policy page set successfully. Remember to update your menus!'.

Thank you

[garrett-eclipse]

Alert after setting Privacy Policy page

[joyously]

I did the same thing, but got the alert twice.

[joyously]

I get double alerts every time I select a different page (and click Use).

This happens even when I select "--Select--".

[garrett-eclipse]

Thanks @joyously that appears to be a unique issue can you open a new Trac Ticket for it so it can be handled seperately. Appreciated

[desrosj]

Marking Privacy change as introduced in 4.9.6.

[garrett-eclipse]

Update notice text to "Privacy Policy page setting updated successfully. Remember to update your menus!"

[garrett-eclipse]

Added 44129.diff to update the verbiage for clarity.

The verbiage used in the patch - "Privacy Policy page setting updated successfully. Remember to update your menus!"

[garrett-eclipse]

Replying to joyously:

I get double alerts every time I select a different page (and click Use).

This happens even when I select "--Select--".

@joyously I wasn't able to reproduce your duplicate notice issue, was there steps? And if you are able to reproduce the issue please create a unique Trac ticket to handle it separately.

Thank you

[audrasjb]

Hello,

5.0.3 is going to be released in a couple of weeks.

It doesn't appear this ticket can be handled in the next couple of weeks (the "double notice" thing will need a double check). Let's address it in 5.1 which is coming in February. Feel free to ask for changing the milestone if you think this issue can be quickly resolved.

Cheers,

Jb

[pento]

In 44493:

Privacy: Tweak the wording of the success notice when updating the privacy policy page setting.

Props garrett-eclipse.
Fixes #44129.