WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 7 months ago

#44129 closed enhancement (fixed)

Setting Privacy Policy page as existing page gives misleading alert

Reported by: garrett-eclipse Owned by: garrett-eclipse
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-screenshots ux-feedback has-patch
Focuses: administration Cc:

Description

Hello,

We have an existing Privacy Policy so using the new tools on 4.9.6 we selected our existing page and clicked 'Use This Page' on the Privacy Settings page. On completion of this action the page reloads with the alert 'Privacy policy page updated successfully. Remember to update your menus!' which made my heart skip a beat thinking the pages content was updated in some way. To avoid this panic and people asking what's been updated on their page maybe this message can be modified to indicate what actually happens, 'Privacy Policy page set successfully. Remember to update your menus!'.

Thank you

Attachments (3)

Screen Shot 2018-05-17 at 1.18.46 PM.png (128.9 KB) - added by garrett-eclipse 15 months ago.
Alert after setting Privacy Policy page
Privacy Settings Demo Site WordPress-2840.jpg (53.5 KB) - added by joyously 15 months ago.
I did the same thing, but got the alert twice.
44129.diff (646 bytes) - added by garrett-eclipse 11 months ago.
Update notice text to "Privacy Policy page setting updated successfully. Remember to update your menus!"

Download all attachments as: .zip

Change History (14)

@garrett-eclipse
15 months ago

Alert after setting Privacy Policy page

@joyously
15 months ago

I did the same thing, but got the alert twice.

#1 follow-up: @joyously
15 months ago

I get double alerts every time I select a different page (and click Use).

This happens even when I select "--Select--".

#2 @garrett-eclipse
15 months ago

Thanks @joyously that appears to be a unique issue can you open a new Trac Ticket for it so it can be handled seperately. Appreciated

#3 @desrosj
15 months ago

  • Version changed from trunk to 4.9.6

Marking Privacy change as introduced in 4.9.6.

#4 @pratikthink
15 months ago

  • Keywords has-screenshots needs-patch ux-feedback added

@garrett-eclipse
11 months ago

Update notice text to "Privacy Policy page setting updated successfully. Remember to update your menus!"

#5 @garrett-eclipse
11 months ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to garrett-eclipse
  • Status changed from new to assigned

Added 44129.diff to update the verbiage for clarity.

The verbiage used in the patch - "Privacy Policy page setting updated successfully. Remember to update your menus!"

#6 in reply to: ↑ 1 @garrett-eclipse
11 months ago

Replying to joyously:

I get double alerts every time I select a different page (and click Use).

This happens even when I select "--Select--".

@joyously I wasn't able to reproduce your duplicate notice issue, was there steps? And if you are able to reproduce the issue please create a unique Trac ticket to handle it separately.

Thank you

#7 @garrett-eclipse
10 months ago

  • Milestone changed from Awaiting Review to 5.0.1

#8 @pento
8 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#9 @pento
8 months ago

  • Milestone changed from 5.0.2 to 5.0.3

#10 @audrasjb
8 months ago

  • Milestone changed from 5.0.3 to 5.1

Hello,

5.0.3 is going to be released in a couple of weeks.

It doesn't appear this ticket can be handled in the next couple of weeks (the "double notice" thing will need a double check). Let's address it in 5.1 which is coming in February. Feel free to ask for changing the milestone if you think this issue can be quickly resolved.

Cheers,

Jb

#11 @pento
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44493:

Privacy: Tweak the wording of the success notice when updating the privacy policy page setting.

Props garrett-eclipse.
Fixes #44129.

Note: See TracTickets for help on using tickets.