WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 4 days ago

#44131 reopened enhancement

If draft page selected for Privacy Policy page should verbiage change from view to preview

Reported by: garrett-eclipse Owned by: azaozz
Milestone: 4.9.7 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch fixed-major
Focuses: administration Cc:

Description

Hello,

Super minor, but should the verbiage on the Privacy Settings page switch from view to preview when the page you've selected for Privacy Policy page is in draft mode?

See screen for verbiage I'm speaking on, it's the 'Edit or view your privacy policy page content.'

Cheers

Attachments (5)

Screen Shot 2018-05-17 at 1.32.12 PM.png (11.4 KB) - added by garrett-eclipse 5 weeks ago.
View vs Preview link
44131.diff (976 bytes) - added by desrosj 2 weeks ago.
Screen Shot 2018-06-06 at 3.24.55 PM.png (164.1 KB) - added by desrosj 2 weeks ago.
Screenshot with a bit more context
44131.2.diff (978 bytes) - added by desrosj 2 weeks ago.
Switch conditions and check for publish instead of draft.
Screen Shot 2018-06-06 at 5.00.26 PM.png (135.0 KB) - added by desrosj 2 weeks ago.
Behavior when Privacy Policy is trashed.

Download all attachments as: .zip

Change History (14)

@garrett-eclipse
5 weeks ago

View vs Preview link

#1 @desrosj
5 weeks ago

  • Version changed from trunk to 4.9.6

Marking Privacy change as introduced in 4.9.6.

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


3 weeks ago

#3 @desrosj
3 weeks ago

  • Milestone changed from Awaiting Review to 4.9.7

@desrosj
2 weeks ago

#4 @desrosj
2 weeks ago

  • Keywords has-patch needs-testing added

@desrosj
2 weeks ago

Screenshot with a bit more context

@desrosj
2 weeks ago

Switch conditions and check for publish instead of draft.

#5 @desrosj
2 weeks ago

44131.2.diff adjusts the text to read "preview" instead of "view" when the selected privacy policy page is not published.

I originally checked if a page was in draft status, but then thought about pages that may have other statuses. Scheduled pages should also read "preview", so switching the condition to check if a page is publish will also display "preview" for scheduled pages.

One other instance to consider is private pages. While private, and scheduled are not supported by default, it is possible to select a published page and then change it to private or scheduled.

When a page is move to the trash, the user does see a notice on the Settings > Privacy page (screenshot incoming).

I opened #44320 to explore how we are notifying users of issues with their site's privacy policy a bit further.

@desrosj
2 weeks ago

Behavior when Privacy Policy is trashed.

#6 @garrett-eclipse
2 weeks ago

Niiice this is awesome thanks @desrosj

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


4 days ago

#8 @azaozz
4 days ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43374:

Privacy: on the Privacy Settings screen change view to preview when a draft page is selected for the privacy policy.

Props garrett-eclipse, desrosj.
Fixes #44131.

#9 @azaozz
4 days ago

  • Keywords fixed-major added; needs-testing removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.9.7.

Note: See TracTickets for help on using tickets.