WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 2 hours ago

#44135 new enhancement

Have Erasure button workflow follow Export button workflow replacing with static link

Reported by: garrett-eclipse Owned by:
Milestone: 4.9.7 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: ui-feedback has-patch needs-testing
Focuses: administration Cc:

Description

Hello,

On the export workflow when you click the Email Data button it ends up going away replaced with a static ‘Email Sent’ message On the removal workflow when you click the remove you get the inline alert but the buttons goes back to actionable state which makes you feel you should click it again. should it not instead go to a static text of ‘Data Removed’ to avoid repeatedly clicking.

Thanks

Attachments (7)

Screen Shot 2018-05-17 at 2.02.45 PM.png (16.1 KB) - added by garrett-eclipse 5 weeks ago.
Email Sent
Screen Shot 2018-05-17 at 2.02.39 PM.png (23.2 KB) - added by garrett-eclipse 5 weeks ago.
Data Erased
44135.diff (2.1 KB) - added by allendav 12 days ago.
erase-completed-1.jpg (30.0 KB) - added by birgire 11 days ago.
erase-completed-2.jpg (30.9 KB) - added by birgire 11 days ago.
44135.2.diff (2.5 KB) - added by allendav 11 days ago.
Dark non clickable privacy request row actions slightly
erase-completed-1b.jpg (20.7 KB) - added by birgire 10 days ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


2 weeks ago

#2 @desrosj
2 weeks ago

  • Keywords needs-patch ui-feedback added
  • Milestone changed from Awaiting Review to 4.9.7
  • Version changed from trunk to 4.9.6

This ticket was mentioned in Slack in #core-privacy by allendav. View the logs.


12 days ago

@allendav
12 days ago

#4 @allendav
12 days ago

  • Keywords has-patch needs-testing added; needs-patch removed

To test:

  • Create a new request
  • Use the Force Erase Personal Data action flow to erase their data
  • Ensure the action text changes to "Erase completed." when it completes.
  • Resend the request to get it back to pending state
  • Confirm the request email
  • Use the Erase Personal Data button to erase their data
  • Ensure the button is replaced with "Erase completed." when it completes

I chose "Erase completed." instead of "Data removed" in the event no data was found to erase - that way the message still makes sense.

Last edited 12 days ago by allendav (previous) (diff)

#5 @birgire
11 days ago

Thanks @allendav for the patch and detailed test steps.

I tested the patch and followed the test steps:

✔️ Create a new request

✔️ Use the Force Erase Personal Data action flow to erase their data

✔️ Ensure the action text changes to "Erase completed." when it completes.

See erase-completed-1.jpg

I noticed that the action row text is hardly readable because of the light coloring:

.row-actions {
    color: #ddd;
    ...
}

Could we make it darker? E.g. with color: #555;, same color as .widefat td and .widefat th.

The same goes for other row action texts, e.g. the Download has failed. for erase requests.

✔️ Resend the request to get it back to pending state

✔️ Confirm the request email

✔️ Use the Erase Personal Data button to erase their data

✔️ Ensure the button is replaced with "Erase completed." when it completes

See erase-completed-2.jpg

I chose "Erase completed." instead of "Data removed" in the event no data was found to erase - that way the message still makes sense.

That makes sense.

Last edited 11 days ago by birgire (previous) (diff)

@allendav
11 days ago

Dark non clickable privacy request row actions slightly

#6 @allendav
11 days ago

@birgire - in 44135.2.diff I changed the color to 999 - let me know what you think - I wanted to still convey that the hover cell action was disabled/not-clickable, so I didn't go for the full on 555 like in other contexts for these tables.

#7 @birgire
10 days ago

I wanted to still convey that the hover cell action was disabled/not-clickable, so I didn't go for the full on 555 like in other contexts for these tables.

erase-completed-1b.jpg shows the #999 color.

The #999 color looks suitable for a disabled context and it's also still easier to read than #ddd. So this looks good to me.

(I haven't checked though, if there's a documented standardized admin color for this context)

@allendav, when trying to test the css, I see why you created ticket #44328 :-)

Last edited 10 days ago by birgire (previous) (diff)

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


2 hours ago

Note: See TracTickets for help on using tickets.