Opened 6 years ago
Closed 5 years ago
#44135 closed enhancement (fixed)
Have Erasure button workflow follow Export button workflow replacing with static link
Reported by: | garrett-eclipse | Owned by: | garrett-eclipse |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | 4.9.6 |
Component: | Privacy | Keywords: | has-patch commit |
Focuses: | administration | Cc: |
Description
Hello,
On the export workflow when you click the Email Data button it ends up going away replaced with a static ‘Email Sent’ message
On the removal workflow when you click the remove you get the inline alert but the buttons goes back to actionable state which makes you feel you should click it again. should it not instead go to a static text of ‘Data Removed’ to avoid repeatedly clicking.
Thanks
Attachments (14)
Change History (52)
This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.
6 years ago
#2
@
6 years ago
- Keywords needs-patch ui-feedback added
- Milestone changed from Awaiting Review to 4.9.7
- Version changed from trunk to 4.9.6
This ticket was mentioned in Slack in #core-privacy by allendav. View the logs.
6 years ago
#4
@
6 years ago
- Keywords has-patch needs-testing added; needs-patch removed
To test:
- Create a new request
- Use the Force Erase Personal Data action flow to erase their data
- Ensure the action text changes to "Erase completed." when it completes.
- Resend the request to get it back to pending state
- Confirm the request email
- Use the Erase Personal Data button to erase their data
- Ensure the button is replaced with "Erase completed." when it completes
I chose "Erase completed." instead of "Data removed" in the event no data was found to erase - that way the message still makes sense.
#5
@
6 years ago
Thanks @allendav for the patch and detailed test steps.
I tested the patch and followed the test steps:
✔️ Create a new request
✔️ Use the Force Erase Personal Data action flow to erase their data
✔️ Ensure the action text changes to "Erase completed." when it completes.
I noticed that the action row text is hardly readable because of the light coloring:
.row-actions { color: #ddd; ... }
Could we make it darker? E.g. with color: #555;
, same color as .widefat td
and .widefat th
.
The same goes for other row action texts, e.g. the Download has failed. for erase requests.
✔️ Resend the request to get it back to pending state
✔️ Confirm the request email
✔️ Use the Erase Personal Data button to erase their data
✔️ Ensure the button is replaced with "Erase completed." when it completes
I chose "Erase completed." instead of "Data removed" in the event no data was found to erase - that way the message still makes sense.
That makes sense.
#6
@
6 years ago
@birgire - in 44135.2.diff I changed the color to 999 - let me know what you think - I wanted to still convey that the hover cell action was disabled/not-clickable, so I didn't go for the full on 555 like in other contexts for these tables.
#7
follow-up:
↓ 11
@
6 years ago
I wanted to still convey that the hover cell action was disabled/not-clickable, so I didn't go for the full on 555 like in other contexts for these tables.
erase-completed-1b.jpg shows the #999
color.
The #999
color looks suitable for a disabled context and it's also still easier to read than #ddd
. So this looks good to me.
(I haven't checked though, if there's a documented standardized admin color for this context)
@allendav, when trying to test the css, I see why you created ticket #44328 :-)
This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.
6 years ago
#9
@
6 years ago
- Milestone changed from 4.9.7 to 4.9.8
4.9.7 has been released, moving to next milestone.
This ticket was mentioned in Slack in #core by jon_bossenger. View the logs.
6 years ago
#11
in reply to:
↑ 7
@
6 years ago
Replying to birgire:
I wanted to still convey that the hover cell action was disabled/not-clickable, so I didn't go for the full on 555 like in other contexts for these tables.
erase-completed-1b.jpg shows the
#999
color.
The
#999
color looks suitable for a disabled context and it's also still easier to read than#ddd
. So this looks good to me.
(I haven't checked though, if there's a documented standardized admin color for this context)
@allendav, when trying to test the css, I see why you created ticket #44328 :-)
Howdy! Responding per our bug-scrub today in #Core. I checked the #999 color against two contrast checkers; just to see if it passes accessibility needs (https://webaim.org/resources/contrastchecker/ and https://contrastchecker.com/).
#999 fails all the accessibility checks. # 72777C seems to pass all but one contrast test, and we're already using it in the admin. See here: https://d.pr/i/3LTFzm.
If someone from the accessibility team can weigh in that'd be awesome! Otherwise my recommendation would be to go with # 72777C
This ticket was mentioned in Slack in #design by joshuawold. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.
6 years ago
#14
@
6 years ago
- Keywords needs-refresh added; ui-feedback removed
Needs color adjusted per @JoshuaWold's feedback.
#15
@
6 years ago
@JoshuaWold thanks for checking it out and the links. I attached your screenshot here Screen Shot on 2018-07-09 at 07_35_24.png just in case the link goes down or changes.
#16
@
6 years ago
I would note a caution in double colouring as seen with blue and green combined in messages. I have to ask why are we showing blue and green together? I would say the following works:
- No color around the actual email itself.
- If successful green
- If no personal data found blue
Grey doesn't really mean anything in terms of this UI so I think lets just not have a double notice color combination and we're set. It after all should only have a notice for information about the state change, not wrap everything.
This ticket was mentioned in Slack in #core by joshuawold. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by pbiron. View the logs.
6 years ago
#19
@
6 years ago
@karmatosed thanks, I wonder if it would be better served as a new ticket, regarding e.g. the mixing of blue/green notices.
44135.3.diff updates the color from #999
to the better contrast of #72777C
, as suggested by @JoshuaWold.
#22
@
6 years ago
It was just decided that we will do 2 betas for 4.9.8. So, I removed the commit
keyword and this ticket will not
be included in beta 1
, giving us one more week to hash out the details of the colors for beta 2
.
This ticket was mentioned in Slack in #core by pbiron. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by joshuawold. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-privacy by webdevlaw. View the logs.
6 years ago
#29
@
6 years ago
- Keywords needs-refresh ui-feedback ux-feedback added
It seems this needs some final decisions on colours and then a final refresh to move back into testing and commit.
#30
@
6 years ago
Related - #44133
The indication of no personal data in export as a notice in admin was raised while working on the above.
#31
@
5 years ago
- Keywords needs-refresh ui-feedback ux-feedback removed
- Owner set to garrett-eclipse
- Status changed from new to accepted
Thanks @allendav / @birgire for the starting patches.
I've refreshed them accounting for two items;
- Updated to account for the privacy re-org from #43895
- Replaced 'display:none;' usage with .hidden as that path was paved with #44839
As well as branched @karmatosed feedback (thank you) into a separate ticket so we don't lose Trac of it.
#47491
Also greatly appreciate the initial design feedback @JoshuaWold.
Please test and we'll line up for 5.3.
This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.
5 years ago
#36
@
5 years ago
@garrett-eclipse Is "Erase completed" correct English? (To me it seems it should be either "Erase operation completed" or "Erasure completed", since "erase" is a verb.
#37
@
5 years ago
- Keywords commit added; needs-testing removed
Good catch thanks @pputzer, in 44135.5.diff I've updated incorrect strings to the following;
- Erasure completed.
- Data Erasure has failed.
- Force Erasure has failed.
As well as ran tests to illustrate the workflow change. This is looking ship-shape so marking as such.
Email Sent