WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 17 months ago

Last modified 15 months ago

#44139 closed defect (bug) (fixed)

i18n: "About" disambiguation

Reported by: Nao Owned by: XpertOne
Milestone: 4.9.8 Priority: normal
Severity: minor Version: 4.9.6
Component: I18N Keywords: has-patch good-first-bug
Focuses: Cc:
PR Number:

Description

”About" label is used as the page title of wp-admin/about.php and the header in the GDPR personal data export HTML page.

https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/about.php?marks=14#L14
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/includes/file.php?marks=1955#L1955

In some languages, the word "About" can't really be translated by itself without knowing what it is about.

Why don't we use these 2 strings separate text? I propose:

  • "About WordPress" as the page title
  • "About Your Data" as the exported page header

Attachments (7)

Personal_Data_Export.png (46.4 KB) - added by Nao 19 months ago.
Personal data export HTML file
file.diff (637 bytes) - added by XpertOne 19 months ago.
about.diff (377 bytes) - added by XpertOne 19 months ago.
44139.diff (1.1 KB) - added by XpertOne 19 months ago.
44139.2.diff (896 bytes) - added by desrosj 18 months ago.
44139.3.diff (1.2 KB) - added by XpertOne 17 months ago.
44139.4.diff (999 bytes) - added by desrosj 17 months ago.

Download all attachments as: .zip

Change History (35)

@Nao
19 months ago

Personal data export HTML file

#1 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 4.9.7

#2 @swissspidy
19 months ago

We can also just add a context to each string.

#3 @Nao
19 months ago

@swissspidy Yeah, that's fine by me as well. I thought spelling it all out makes it easier to translate, but as long as they are separated I'm ok.

#4 @desrosj
19 months ago

  • Keywords good-first-bug added

Adding good-first-bug.

@XpertOne
19 months ago

@XpertOne
19 months ago

#5 @XpertOne
19 months ago

  • Keywords has-patch added; good-first-bug removed

#6 follow-up: @swissspidy
19 months ago

  • Keywords good-first-bug added
  • Owner set to XpertOne
  • Status changed from new to assigned

#7 @desrosj
19 months ago

  • Milestone changed from 4.9.7 to 4.9.8

Moving all tickets in 4.9.7 to 4.9.8.

#8 in reply to: ↑ 6 @XpertOne
19 months ago

Replying to swissspidy:
my first patch , not sure if that is good to be accepted.

This ticket was mentioned in Slack in #core by kashif. View the logs.


19 months ago

@XpertOne
19 months ago

#10 @SergeyBiryukov
19 months ago

  • Milestone changed from 4.9.8 to 4.9.7

#11 @desrosj
19 months ago

  • Keywords needs-refresh added

Thanks for the patch, @XpertOne! Welcome to Trac!

44139.diff is the right format to provide a patch. Can we change it to only introduce a context for each string (leave both strings as "About") per @swissspidy's suggestion?

Also, the context in the patch still does not describe the context very well. Maybe "Page title of the about WordPress page in the admin." and "Header for the About section in a personal data export, which contains general site details."?

@desrosj
18 months ago

#12 @desrosj
18 months ago

  • Keywords ui-feedback needs-refresh removed

#13 @swissspidy
18 months ago

@desrosj FYI That patch will still result in 1 string, just with two translator conments. It would still need a context using _x()

#14 @ocean90
17 months ago

  • Milestone changed from 4.9.7 to 4.9.8

4.9.7 has been released, moving to next milestone.

@XpertOne
17 months ago

#15 @pbiron
17 months ago

Is this ready to land in 4.9.8? Beta is scheduled for July 17, next Tues.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


17 months ago

This ticket was mentioned in Slack in #polyglots by pbiron. View the logs.


17 months ago

#18 @XpertOne
17 months ago

@pbiron any suggestions on context improvement you mentioned on Slack ?

#19 @pbiron
17 months ago

not really, since I'm not a translator.

The fact that the context string in the patch didn't make sense to at lease one translator suggests that it might need something more.

This ticket was mentioned in Slack in #core by jon_bossenger. View the logs.


17 months ago

#21 @swissspidy
17 months ago

44139.3.diff doesn't work as translators must directly preceed the _x() call.

Why not just use 44139.2.diff together with _x( 'About', 'page title' ) and `_x( 'About', ?

@desrosj
17 months ago

This ticket was mentioned in Slack in #core by pbiron. View the logs.


17 months ago

#24 @swissspidy
17 months ago

_x( 'About', 'group label' ) would be the only group label with that context.

Since there are a few other group labels with indistinctive strings like __( 'Comments' ), we should consider adding the same context to these too for consistency. Not sure if "group label" is the best one.

@ocean90 @SergeyBiryukov thoughts?

#25 @SergeyBiryukov
17 months ago

44139.4.diff looks OK to me.

Other group labels (Comments, Media, User) could get the same context too, but unless there's an actual use case for them to be translated differently (as is with About here), that's probably not necessary.

#26 @SergeyBiryukov
17 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43527:

I18N: Separate two "About" strings with different context.

Props desrosj, XpertOne, Nao.
Fixes #44139.

#27 @SergeyBiryukov
17 months ago

In 43528:

I18N: Separate two "About" strings with different context.

Props desrosj, XpertOne, Nao.
Merges [43527] to the 4.9 branch.
Fixes #44139.

This ticket was mentioned in Slack in #polyglots by nao. View the logs.


15 months ago

Note: See TracTickets for help on using tickets.