WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 30 hours ago

#44139 assigned defect (bug)

i18n: "About" disambiguation

Reported by: Nao Owned by: XpertOne
Milestone: 4.9.7 Priority: normal
Severity: minor Version: 4.9.6
Component: I18N Keywords: has-patch good-first-bug
Focuses: Cc:

Description

”About" label is used as the page title of wp-admin/about.php and the header in the GDPR personal data export HTML page.

https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/about.php?marks=14#L14 https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/includes/file.php?marks=1955#L1955

In some languages, the word "About" can't really be translated by itself without knowing what it is about.

Why don't we use these 2 strings separate text? I propose:

  • "About WordPress" as the page title
  • "About Your Data" as the exported page header

Attachments (5)

Personal_Data_Export.png (46.4 KB) - added by Nao 5 weeks ago.
Personal data export HTML file
file.diff (637 bytes) - added by XpertOne 5 weeks ago.
about.diff (377 bytes) - added by XpertOne 5 weeks ago.
44139.diff (1.1 KB) - added by XpertOne 4 weeks ago.
44139.2.diff (896 bytes) - added by desrosj 32 hours ago.

Download all attachments as: .zip

Change History (18)

@Nao
5 weeks ago

Personal data export HTML file

#1 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 4.9.7

#2 @swissspidy
5 weeks ago

We can also just add a context to each string.

#3 @Nao
5 weeks ago

@swissspidy Yeah, that's fine by me as well. I thought spelling it all out makes it easier to translate, but as long as they are separated I'm ok.

#4 @desrosj
5 weeks ago

  • Keywords good-first-bug added

Adding good-first-bug.

@XpertOne
5 weeks ago

@XpertOne
5 weeks ago

#5 @XpertOne
5 weeks ago

  • Keywords has-patch added; good-first-bug removed

#6 follow-up: @swissspidy
5 weeks ago

  • Keywords good-first-bug added
  • Owner set to XpertOne
  • Status changed from new to assigned

#7 @desrosj
5 weeks ago

  • Milestone changed from 4.9.7 to 4.9.8

Moving all tickets in 4.9.7 to 4.9.8.

#8 in reply to: ↑ 6 @XpertOne
5 weeks ago

Replying to swissspidy: my first patch , not sure if that is good to be accepted.

This ticket was mentioned in Slack in #core by kashif. View the logs.


4 weeks ago

@XpertOne
4 weeks ago

#10 @SergeyBiryukov
4 weeks ago

  • Milestone changed from 4.9.8 to 4.9.7

#11 @desrosj
3 weeks ago

  • Keywords needs-refresh added

Thanks for the patch, @XpertOne! Welcome to Trac!

44139.diff is the right format to provide a patch. Can we change it to only introduce a context for each string (leave both strings as "About") per @swissspidy's suggestion?

Also, the context in the patch still does not describe the context very well. Maybe "Page title of the about WordPress page in the admin." and "Header for the About section in a personal data export, which contains general site details."?

@desrosj
32 hours ago

#12 @desrosj
32 hours ago

  • Keywords ui-feedback needs-refresh removed

#13 @swissspidy
30 hours ago

@desrosj FYI That patch will still result in 1 string, just with two translator conments. It would still need a context using _x()

Note: See TracTickets for help on using tickets.