#44139 closed defect (bug) (fixed)
i18n: "About" disambiguation
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9.8 | Priority: | normal |
Severity: | minor | Version: | 4.9.6 |
Component: | I18N | Keywords: | has-patch good-first-bug |
Focuses: | Cc: |
Description
”About" label is used as the page title of wp-admin/about.php
and the header in the GDPR personal data export HTML page.
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/about.php?marks=14#L14
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/includes/file.php?marks=1955#L1955
In some languages, the word "About" can't really be translated by itself without knowing what it is about.
Why don't we use these 2 strings separate text? I propose:
- "About WordPress" as the page title
- "About Your Data" as the exported page header
Attachments (7)
Change History (35)
#3
@
7 years ago
@swissspidy Yeah, that's fine by me as well. I thought spelling it all out makes it easier to translate, but as long as they are separated I'm ok.
#6
follow-up:
↓ 8
@
7 years ago
- Keywords good-first-bug added
- Owner set to XpertOne
- Status changed from new to assigned
#8
in reply to:
↑ 6
@
7 years ago
Replying to swissspidy:
my first patch , not sure if that is good to be accepted.
This ticket was mentioned in Slack in #core by kashif. View the logs.
7 years ago
#11
@
7 years ago
- Keywords needs-refresh added
Thanks for the patch, @XpertOne! Welcome to Trac!
44139.diff is the right format to provide a patch. Can we change it to only introduce a context for each string (leave both strings as "About") per @swissspidy's suggestion?
Also, the context in the patch still does not describe the context very well. Maybe "Page title of the about WordPress page in the admin." and "Header for the About section in a personal data export, which contains general site details."?
#13
@
7 years ago
@desrosj FYI That patch will still result in 1 string, just with two translator conments. It would still need a context using _x()
#14
@
7 years ago
- Milestone changed from 4.9.7 to 4.9.8
4.9.7 has been released, moving to next milestone.
This ticket was mentioned in Slack in #core by pbiron. View the logs.
7 years ago
This ticket was mentioned in Slack in #polyglots by pbiron. View the logs.
7 years ago
#19
@
7 years ago
not really, since I'm not a translator.
The fact that the context string in the patch didn't make sense to at lease one translator suggests that it might need something more.
This ticket was mentioned in Slack in #core by jon_bossenger. View the logs.
7 years ago
#21
@
7 years ago
44139.3.diff doesn't work as translators must directly preceed the _x()
call.
Why not just use 44139.2.diff together with _x( 'About', 'page title' )
and `_x( 'About', ?
#22
@
7 years ago
44139.4.diff combines 44139.2.diff with _x()
.
This ticket was mentioned in Slack in #core by pbiron. View the logs.
7 years ago
#24
@
7 years ago
_x( 'About', 'group label' )
would be the only group label with that context.
Since there are a few other group labels with indistinctive strings like __( 'Comments' )
, we should consider adding the same context to these too for consistency. Not sure if "group label" is the best one.
@ocean90 @SergeyBiryukov thoughts?
#25
@
7 years ago
44139.4.diff looks OK to me.
Other group labels (Comments
, Media
, User
) could get the same context too, but unless there's an actual use case for them to be translated differently (as is with About
here), that's probably not necessary.
Personal data export HTML file