WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44162, comment 9


Ignore:
Timestamp:
06/01/2018 07:00:19 PM (7 years ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #44162, comment 9

    initial v1  
    1 Prefacing my feedback by reiterating he is_countable() function should only be used before counting a value where it's valid for either a countable or non-countable value to be passed. See [ticket:44123#comment:11] for a longer explanation.
     1Prefacing my feedback by reiterating the is_countable() function should only be used before counting a value where it's valid for either a countable or non-countable value to be passed. See [ticket:44123#comment:11] for a longer explanation.
    22
    33I don't think that these occurrences of `count()` should be preceded by an `is_countable()` check. All three functions (`get_users()`, `wp_get_post_revisions()`, and `get_page_templates()`) should always return arrays. If arrays are not returned, this is a bug and the PHP warning should not be suppressed.