WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44168, comment 3


Ignore:
Timestamp:
06/01/2018 07:40:14 PM (18 months ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44168, comment 3

    initial v1  
    11Thanks for your work on this, @thrijith!
    22
    3 I do not think that `is_countable()` is needed for any of these instances of `count()`, though. `is_countable()` should only be used before counting a value where it's valid for either a countable or non-countable value to be passed (see [ticket 44123#comment:11).
     3I do not think that `is_countable()` is needed for any of these instances of `count()`, though. `is_countable()` should only be used before counting a value where it's valid for either a countable or non-countable value to be passed (see [ticket:44123#comment:11]).
    44
    55- While it is possible for the `get_ancestors()` function to return an uncountable value if a plugin or theme incorrectly uses the `get_ancestors` filter, this would be a bug.