Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #44176, comment 22


Ignore:
Timestamp:
12/19/2019 04:12:34 PM (6 years ago)
Author:
xkon
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44176, comment 22

    v1 v2  
    55Let me explain what this patch does and where I'm facing some issues to see if we can figure out something either with or without the role ( it's easy this way to simply apply the patch and do a `wp role reset --all` so the DPO can be created to check it out ).
    66
    7 First of all, it splits the caps into manage_privacy_options, export_others_personal_data & erase_others_personal_data ( I'm not even sure if we need all 3 to be honest as it doesn't make much sense to me to allow 1 and not the other but I just used what we have already in :) ).
     7First of all, it splits the caps into manage_privacy_options, export_others_personal_data & erase_others_personal_data on their own.
    88
    991] Changes the `erasure` procedures to not need the `delete_user` cap as these can be specifically applied to users now.
     
    4949The caps after this are accessible from plugins like the "Member" that was mentioned here and they can be assigned to different roles also.
    5050
    51 I would love feedback on how to tackle the menu problem and if we really need 3 different caps for Privacy. Again it doesn't make any sense at all to me to split 3 and everything would be way easier if we just had `manage_privacy_options` only.
     51I would love feedback on how to tackle the menu problem as I don't like much the if statement there and not really sure if it's ok to do it that way.