![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#44181 closed enhancement (fixed)
The input field id username_or_email_to_export should be something else on remove_personal_data page
| Reported by: | allendav | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9.8 |
| Component: | Privacy | Version: | 4.9.6 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | administration |
Description
Minor.
On wp-admin/tools.php?page=remove_personal_data
And as handled in wp-admin/includes/user.php in _wp_personal_data_handle_actions
Note that presently, the logic (regardless of erase or export) is using $_POST username_or_email_to_export
It should either be renamed on the remove_personal_data page, or a more generic POST variable name chosen for both remove_personal_data and export_personal_data (e.g. username_or_email_for_privacy_request)
Attachments (1)
Change History (11)
#1
@
8 years ago
- Focuses administration added
- Keywords has-patch added; needs-patch removed
- Version trunk → 4.9.6
This ticket was mentioned in Slack in #core by jon_bossenger. View the logs.
8 years ago
#3
@
8 years ago
- Keywords gdpr removed
Removing the GDPR keyword. This has been replaced by the new Privacy component and privacy focuses in Trac.
#4
@
8 years ago
This change makes sense to me. I tested and everything is working as it should. I wonder if any plugins or themes are using this $_POST variable, though. While it's not wrong, it would be a much better approach to add action hooks where additional actions are needed. Not sure that is a blocker, but it's worth noting the very slim potential for a backwards compatibility issue.
Changed all instances of "username_or_email_to_export" to "username_or_email_for_privacy_request" in /wp-admin/includes/user.php