The input field id username_or_email_to_export should be something else on remove_personal_data page

[allendav]

Minor.

On wp-admin/tools.php?page=remove_personal_data

And as handled in wp-admin/includes/user.php in _wp_personal_data_handle_actions

Note that presently, the logic (regardless of erase or export) is using $_POST username_or_email_to_export

It should either be renamed on the remove_personal_data page, or a more generic POST variable name chosen for both remove_personal_data and export_personal_data (e.g. username_or_email_for_privacy_request)

[ianbelanger]

Changed all instances of "username_or_email_to_export" to "username_or_email_for_privacy_request" in /wp-admin/includes/user.php

[desrosj]

Removing the GDPR keyword. This has been replaced by the new Privacy component and privacy focuses in Trac.

[desrosj]

This change makes sense to me. I tested and everything is working as it should. I wonder if any plugins or themes are using this $_POST variable, though. While it's not wrong, it would be a much better approach to add action hooks where additional actions are needed. Not sure that is a blocker, but it's worth noting the very slim potential for a backwards compatibility issue.

[pento]

This is fine to commit and backport, I don't think we need to be concerned about the potential back compat issue.

[SergeyBiryukov]

Searched the plugin repo for username_or_email_to_export, haven't found anything.

[SergeyBiryukov]

In 43478:

Privacy: Rename username_or_email_to_export POST variable on Erase Personal Data screen to a more generic username_or_email_for_privacy_request.

Props ianbelanger, allendav.
Fixes #44181.

[SergeyBiryukov]

In 43479:

Privacy: Rename username_or_email_to_export POST variable on Erase Personal Data screen to a more generic username_or_email_for_privacy_request.

Props ianbelanger, allendav.
Merges [43478] to the 4.9 branch.
Fixes #44181.