Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#44185 closed defect (bug) (fixed)

Removed wrong parameter and updated some improper doc blocks

Reported by: rafsuntaskin's profile rafsuntaskin Owned by: pento's profile pento
Milestone: 5.1 Priority: low
Severity: normal Version:
Component: Rewrite Rules Keywords: has-patch
Focuses: Cc:

Description

iis7_url_rewrite_rules accepts only 1 param but previously it was used with 3 params which is deprecated now. Removed the extra empty params.

Adjusted some doc blocks of multiple functions.

Attachments (3)

remove-extra-param.diff (740 bytes) - added by rafsuntaskin 8 years ago.
Removed unnecessary params
updated-doc-blocks.diff (1.1 KB) - added by rafsuntaskin 8 years ago.
Update doc blocks
updated-doc-blocks-2.diff (845 bytes) - added by rafsuntaskin 8 years ago.
removed changing access doc

Download all attachments as: .zip

Change History (12)

@rafsuntaskin
8 years ago

Removed unnecessary params

@rafsuntaskin
8 years ago

Update doc blocks

#1 @johnbillion
8 years ago

  • Component changed from General to Rewrite Rules
  • Milestone changed from Awaiting Review to 5.0
  • Owner set to johnbillion
  • Priority changed from normal to low
  • Status changed from new to reviewing

#2 follow-up: @swissspidy
8 years ago

Why did you remove the @access private part for _policy_page_updated? That seems totally unrelated.

#3 in reply to: ↑ 2 @rafsuntaskin
8 years ago

Replying to swissspidy:

Why did you remove the @access private part for _policy_page_updated? That seems totally unrelated.

OK, I think I misread it with public function access.

@rafsuntaskin
8 years ago

removed changing access doc

#4 @johnbillion
7 years ago

  • Milestone changed from 5.0 to 5.0.1

#5 @pento
7 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @pento
7 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#7 @audrasjb
7 years ago

  • Milestone changed from 5.0.3 to 5.1

Hello,

5.0.3 is going to be released in a couple of weeks.

It doesn't appear this ticket can be handled in the next couple of weeks (still needs review from component maintainers). Let's address it in 5.1 which is coming in February. Feel free to ask for changing the milestone if you think this issue can be quickly resolved.

Cheers,

Jb

#8 @pento
7 years ago

  • Owner changed from johnbillion to pento
  • Status changed from reviewing to accepted

#9 @pento
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 44619:

Rewrite: Remove extra arguments being passed to WP_Rewrite::iis7_url_rewrite_rules().

Props rafsuntaskin.
Fixes #44185.

Note: See TracTickets for help on using tickets.