WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 4 weeks ago

#44185 reviewing defect (bug)

Removed wrong parameter and updated some improper doc blocks

Reported by: rafsuntaskin Owned by: johnbillion
Milestone: 5.0 Priority: low
Severity: normal Version:
Component: Rewrite Rules Keywords: has-patch
Focuses: Cc:

Description

iis7_url_rewrite_rules accepts only 1 param but previously it was used with 3 params which is deprecated now. Removed the extra empty params.

Adjusted some doc blocks of multiple functions.

Attachments (3)

remove-extra-param.diff (740 bytes) - added by rafsuntaskin 5 weeks ago.
Removed unnecessary params
updated-doc-blocks.diff (1.1 KB) - added by rafsuntaskin 5 weeks ago.
Update doc blocks
updated-doc-blocks-2.diff (845 bytes) - added by rafsuntaskin 4 weeks ago.
removed changing access doc

Download all attachments as: .zip

Change History (6)

@rafsuntaskin
5 weeks ago

Removed unnecessary params

@rafsuntaskin
5 weeks ago

Update doc blocks

#1 @johnbillion
5 weeks ago

  • Component changed from General to Rewrite Rules
  • Milestone changed from Awaiting Review to 5.0
  • Owner set to johnbillion
  • Priority changed from normal to low
  • Status changed from new to reviewing

#2 follow-up: @swissspidy
5 weeks ago

Why did you remove the @access private part for _policy_page_updated? That seems totally unrelated.

#3 in reply to: ↑ 2 @rafsuntaskin
4 weeks ago

Replying to swissspidy:

Why did you remove the @access private part for _policy_page_updated? That seems totally unrelated.

OK, I think I misread it with public function access.

@rafsuntaskin
4 weeks ago

removed changing access doc

Note: See TracTickets for help on using tickets.