Title of Privacy Policy Page not used on login page

[Ov3rfly]

1. Have a page with some title like "Imprint and Privacy Policy"
2. Set as "Privacy Policy Page"

Current Behaviour:

3. Link on login page does not use the page title.

Expected Behaviour:

3. Link on login page uses the page title.

[knutsp]

Which login page? Do you mean wp-login.php or other?

[Ov3rfly]

The login and registration pages which are mentioned in the new ​Privacy Policy Page description.

[knutsp]

Confirmed on wp-login.php.

The anchor text is "Privacy Policy" or the localized version (translation) of this string, regardless the title of the page.

Should this be fixed, or a "wontfix"?

[Ov3rfly]

As already explained in the example "Imprint and Privacy Policy", the linked page might contain more than a privacy policy and pointing out the availibility of this content at the supplied link might be even legally necessary, e.g. in Germany.

[pento]

I'm inclined to change the behaviour of get_the_privacy_policy_link() to use the post title, rather than a hardcoded string. As suggested, this allows easy customisation of the link text.

For localisation, the post is created with the post title translated to site's current language. For sites that support multiple languages, this should also fit into their content translation flow, as the post title will be localised along with the post content.

[desrosj]

Changes get_the_privacy_policy_link() link text to be the selected Privacy Policy page's post title. Includes unit test.

[ianbelanger]

@desrosj Just tested your diff and all seems to be working fine for me. I changed my Privacy Policy page title and the hyperlinked text changed on the login page. I did not run the unit test though. Will do that later and report back. Screenshot coming.

[ianbelanger]

Example of login page Privacy Policy text

[ianbelanger]

Unit tests passed, see results below:

..... 5 / 5 (100%)

You should really fix these slow tests (>150ms)...

1. 465ms to run Tests_Link_GetThePrivacyPolicyLink:test_get_the_privacy_policy_link_should_return_valid_link_when_privacy_page_set

Time: 3.21 seconds, Memory: 24.00MB

OK (5 tests, 11 assertions)

[desrosj]

44192.2.diff​ adds a check for an empty page title and does not return a link if the privacy policy's page title is empty. This behavior may not be obvious for some users, but I am not sure we should assume "Privacy Policy" should be used in the absence of an actual page title.

[ianbelanger]

Just tested the latest patch and the Privacy Policy link is removed when
there is no title for the Privacy Policy page.

Nice work @desrosj

[ocean90]

4.9.7 has been released, moving to next milestone.

[xkon]

@desrosj everything looks good here :)

[birgire]

44192.3.diff​ has just few suggestions, based on 44192.2.diff​ :

• Escapes the privacy page title within the output of get_the_privacy_policy_link().
• Adds the annotation @ticket 44192 for the new test method.
• Adjusts to the new test method name and description.
• As assertEmpty() results true for more than an empty string, e.g. null, false, I replaced it with assertSame( '', ... ), similar as in the existing test_get_the_privacy_policy_link_should_return_empty_string_when_privacy_page_not_set() method.
• Combines assertions in test_get_the_privacy_policy_link_should_return_valid_link_when_privacy_page_set().

[pbiron]

Can this land in 4.9.8?

[SergeyBiryukov]

In 43506:

Privacy: Use the actual Privacy Policy page title in get_the_privacy_policy_link().

Props desrosj, birgire, ianbelanger, Ov3rfly.
Fixes #44192.

[SergeyBiryukov]

In 43507:

Privacy: Use the actual Privacy Policy page title in get_the_privacy_policy_link().

Props desrosj, birgire, ianbelanger, Ov3rfly.
Merges [43506] to the 4.9 branch.
Fixes #44192.