Admin Menu SVG Icon colour wrong in Default colour scheme

[swift]

When using a SVG as an icon for an admin menu, the default color scheme shows the svg icons as a different colour (#82878c) than font icons (#a0a5aa). Other colour schemes seem to render svg icons correctly. Seems like it's related to /wp-includes/general-template.php line 3886 (WP 4.9.5), and possibly /wp-admin/includes/misc.php line 713. Changing 'base' => '#82878c' to 'base' => '#a0a5aa' fixes the issue for me.

[swift]

SVG Admin Icon colour wrong in default colour scheme (eg. Conference vs. Comments)

[swift]

patch for this bug

[swift]

I've made a patch for this - it's my first ever so hopefully it's correct.

[dschalk]

I have tested this and can confirm that it works :)

[desrosj]

Assigning to mark good-first-bug claimed. Thanks for the patch, @swift, and thank you for testing @dschalk!

It looks like this color was changed in [36587]. The goal there was to improve color contrast for a11y. This change makes the colors consistent while maintaining a proper level of contrast.

I was able to reproduce the issue with several plugins that use SVG icons, and #44209.diff​ fixed them all for me.

[desrosj]

In 44353:

Administration: Update default fallback color for SVG icons.

Currently, when an SVG is used as a menu icon, the color is inconsistent with the other, default dashicons and the contrast ratio does not meet the minimum requirement for accessibility.

This updates the base color for the default fresh color scheme to ensure consistency and proper contrast.

Props swift, dschalk.
Fixes #44209.

[desrosj]

Reopening for backport consideration.

[desrosj]

Since 5.0.3 is for block editor improvements, regressions, and major bug fixes, let's leave this in 5.1.