WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 weeks ago

#44250 reviewing enhancement

Error silencer @opendir syntax are inconsistently written in different files

Reported by: subrataemfluence Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch 2nd-opinion
Focuses: coding-standards Cc:

Description

We have error silencers like @opendir and @closedir are used in several places of different admin files.

In some areas they appear like @opendir while at some places we have @ opendir. However, @closedir is written consistently.

I think they should be consistent everywhere.

Attachments (3)

error-silencer-plugin.php.diff (1.5 KB) - added by subrataemfluence 3 years ago.
error-silencer-upgrade.php.diff (990 bytes) - added by subrataemfluence 3 years ago.
44250.diff (739 bytes) - added by sabernhardt 9 months ago.
for consistency, this removes the spaces for the remaining two @ opendir instances in wp-admin/includes/plugin.php

Download all attachments as: .zip

Change History (6)

#1 @johnbillion
3 years ago

  • Focuses coding-standards added
  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

#2 @sabernhardt
9 months ago

Changeset [45611] removed the two spaces from wp-admin/includes/upgrade.php plus two of the four in wp-admin/includes/plugin.php. So two remain.

@sabernhardt
9 months ago

for consistency, this removes the spaces for the remaining two @ opendir instances in wp-admin/includes/plugin.php

#3 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 5.8
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.