Missing return statement in function uninstall_plugin

[subrataemfluence]

Function uninstall_plugin is missing a final return statement.

It returns true if a plugin's uninstall.php file has been found and included. But it should return false if the file is not present or not included.

Can we re-write like this?

<?php
function uninstall_plugin( $plugin ) {
   $file = plugin_basename( $plugin );

   $uninstallable_plugins = (array) get_option( 'uninstall_plugins' );

   do_action( 'pre_uninstall_plugin', $plugin, $uninstallable_plugins );

   if ( file_exists( WP_PLUGIN_DIR . '/' . dirname( $file ) . '/uninstall.php' ) )  
   {    ...
        return true;
   }

   if ( isset( $uninstallable_plugins[ $file ] ) ) {
        ...
        return true; //this is missing too
   }

   return false;
}

[afragen]

According to the docBlock the function returns true if the uninstall.php file is found and used.

Only in the first conditional does this happen. There is no mention of returning false only that other options using the supplied hooks are available for use.

[desrosj]

Removing Awaiting Review milestone from closed tickets.