WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 19 months ago

#44263 closed defect (bug) (worksforme)

`grunt build` removes `wp-config.php` file.

Reported by: desrosj Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.1
Component: Build/Test Tools Keywords: dev-feedback
Focuses: Cc:

Description

Every time I run grunt build locally, I am presented with an install screen when running WordPress from the build directory.

Before r43309, the wp-config.php file was created in the src directory. When grunt build runs, it removes everything in the build directory and copies everything in the src directory into build. But now that you can't run WordPress from the src directory, the wp-config.php file is never created in src to be copied to `build.

Change History (8)

#1 @desrosj
2 years ago

Forgot to specify, I am using VVV.

This ticket was mentioned in Slack in #core by azaozz. View the logs.


2 years ago

#3 @jeremyfelt
2 years ago

Poor VVV planning on my part when core moved to the develop.svn workflow . :)

The wp-config-sample.php and wp-config-tests-sample.php files are already in the correct location (project root). VVV (and others') installations via WP-CLI can be adjusted to match. The make/core installing from svn docs already do a pretty good job of referencing it in its correct location.

I don't think there's anything we need to do in core for this one, though having the ticket here will help with awareness.

#4 @azaozz
2 years ago

having the ticket here will help with awareness.

Right. The wp-config.php file should be one level up, in the WP checkout dir, the parent directory of /src and /build. It may need to be moved there after running the install.

The only thing we can possibly do to help from core would be to check the location of wp-config-sample.php and wp-config-tests-sample.php and create wp-config.php next to them. (That looks like a pretty simple patch imho).

Last edited 2 years ago by azaozz (previous) (diff)

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


2 years ago

#6 @pento
19 months ago

  • Keywords close added

Seems like this isn't a problem anymore, since we switched back to running from src?

#7 @afercia
19 months ago

I've never run in this issue because on my VVV the wp-config.php file is in the src directory. It does get copied to build. Maybe this is something that happens only in new VVVs installs?

#8 @pento
19 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.