Non-public custom post types have rewrite rules enabled by default

[TheDeadMedic]

Is there a reason for the pairing of public => false with rewrite => true for default custom post type arguments? If there isn't can we change the default rewrite to inherit public at runtime?

I often see a large rewrite rules array from plugin/theme private post types not declaring rewrite => false - if there's no need for them seems bit of a waste - a default WP install is 17 rules per post type, 17 possible unnecessary regex checks per-request. Usually it's two or three CPTs I see per site and they stack up quick.

[ryanshoover]

Changes rewrite parameter to the default of publicly_queryable

[ryanshoover]

Just submitted a patch that would take care of this need. Changes the default of rewrite to be the value of publicly_queryable (which takes the default of public).

publicly_queryable made the most sense since rewrites determine the pretty URL for a post if you query it on the frontend.