Feature Request: Provide Menu Settings on create new menu

[garrett-eclipse]

Hello,

I wanted to request an improvement to the Menu creation workflow to reduce the workflow. Currently you create a menu with name and then once created can set the Menu Settings for 'Auto add pages' and 'Display location'. It would be nice to have those options available on the create menu screen thus removing a step in the process if you're not adding any menu items.

Thanks

[garrett-eclipse]

Create Menu

[garrett-eclipse]

Menu Settings

[audrasjb]

Hi,

Looks like a nice little enhancement. Adding good-first-bug keyword.

[garrett-eclipse]

After a failed menu creation if any menu locations were selected they become default.

[garrett-eclipse]

Thanks for the patch @ianjvr

I successfully applied against trunk and testing everything seemed to be working until I tried to break it... and by that I mean I tried to save a second menu with the same title as an existing one. In this one circumstance, an issue presents itself in that the failed save updated the database option for theme_mods_twentynineteen to set the nav_menu_locations I'd had selected 'social' against an id of 0;
a:2:{s:18:"custom_css_post_id";i:-1;s:18:"nav_menu_locations";a:2:{s:6:"menu-1";i:4;s:6:"social";i:0;}}
With this set against id 0 when you go to create an additional menu we are presented with pre-selected menu location(s).

I believe the issue here lies in this code which occurs before the menu title is checked for error.
​https://github.com/WordPress/WordPress/blob/master/wp-admin/nav-menus.php#L295-L309

The other tests I did worked nicely they entailed;

1. Creating a menu.
2. Creating a menu w/ auto-add.
3. Creating a menu w/ location(s)
4. Creating a menu w/ both auto-add and location(s)

*Between these tests I reloaded and attempted the location tests with different ones individually and multiples as well.

The only other pause I had while testing was after creating my first menu and going to create my second I wanted to go back but in this case where there's only one existing menu the dropdown select doesn't appear so one either needed to reload or use the sidebar navigation. Due to this I opened (#46367) to suggest adding a Cancel to the Create Menu screen.

Nice work on the patch, and let me know if I can clarify or assist in any way.

Cheers

[garrett-eclipse]

Refreshed patch and addressed setting 0 to nav_menu_locations theme mod which caused a default location to be checked when creating a menu.

[garrett-eclipse]

In 44286.2.diff I've refreshed to patch to apply cleanly as well as address the issue I raised during testing. This was done by moving a set_theme_mod of the cleaned up menu_locations before to only apply for existing menus.

This feels like a good candidate for 5.5, @audrasjb could you take a moment to review/test.
Thank you

[audrasjb]

It's on my list, thanks for the heads up @garrett-eclipse

[audrasjb]

patch refreshed against trunk

[audrasjb]

Patch looks good

[audrasjb]

Hi,

I tested the previous patch and it looks good to me. Works fine, thanks 👍

44286.3.diff is a small refresh against trunk.

[garrett-eclipse]

Thanks for testing @audrasjb let's get a committer review here and I think that's a wrap.

[whyisjake]

This was fixed in [48051], so marking as closed. The committer failed to add the relevant line to auto-close the issue.

[whyisjake]

In 48052:

Code Standards: Cleanup some code spacing.

See: #37826 and #44286.