Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#44294 closed enhancement (wontfix)

Move comment form labels after inputs for consistency with consent checkbox

Reported by: silb3r's profile silb3r Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: accessibility Cc:

Description

The comment form's consent field input element appears before its label element. This patch rearranges the other comment form fields to conform to the same, consistent input/label element order. It also has the benefit of allowing for modern CSS effects and label effects based on the :placeholder-shown psuedo-class.

Attachments (1)

move_comment_labels_after_inputs_for_consistency.diff (3.4 KB) - added by silb3r 6 years ago.
Make all comment form field markup order consistent

Download all attachments as: .zip

Change History (6)

@silb3r
6 years ago

Make all comment form field markup order consistent

#1 @joyously
6 years ago

So instead of changing the new one, you change all the old ones?
How does that work for backward compatibility of all the themes that styled those?

#2 @silb3r
6 years ago

Imho the new one is formatted correctly for modern development. The form labels will end up under their corresponding inputs, and if that's a problem then some simple CSS can fix that, either with flexbox ordering or absolute positioning.

#3 @desrosj
6 years ago

  • Focuses performance removed
  • Keywords has-patch added
  • Version trunk deleted

I'm not sure that I am sold that the labels should be moved after the fields to match the checkbox label. Checkbox fields have always been output before their labels.

Are there other reasons why this change should be made?

#4 @silb3r
6 years ago

I'm not sure that I am sold

If consistency and modern use aren't important then what would sell you on moving them?

#5 @swissspidy
6 years ago

  • Focuses accessibility added; ui template removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The form labels will end up under their corresponding inputs, and if that's a problem then some simple CSS can fix that, either with flexbox ordering or absolute positioning.

That's not really an option.

For usability and accessibility reasons, labels should come _before_ the input fields. Not just visually, but also in the markup.

See https://www.w3.org/WAI/tutorials/forms/labels/#visual-position-of-label-text.

If anything, one could open a ticket for changing the markup for the checkbox while still maintaining it's visual appearance. However, AFAIK assistive technologies handle this markup just fine for checkboxes.

Note: See TracTickets for help on using tickets.