Hook retreive_password (depricated) should be removed

[subrataemfluence]

Since the function retreive_password no longer exists in the framework any more, I think we should remove it from get_password_reset_key function. Currently it has documented as

* @deprecated 1.5.1 Misspelled. Use 'retrieve_password' hook instead.

• File: wp-includes/user.php
• Line number: 2205

Proposed patch added.

[birgire]

There's also the ​do_action_deprecated() function introduced in 4.6:

When an action hook is deprecated, the do_action() call is replaced with do_action_deprecated(), which triggers a deprecation notice and then fires the original hook.

Similarly the ​apply_filters_deprecated() function for deprecated filters.

So in this case it might be replaced with:

do_action_deprecated( 'retreive_password', array( $user->user_login ), '1.5.1', 'retrieve_password' );

It would be interesting to scan the wordpress.org plugin repository to see if any plugin is using this deprecated filter.

@subrataemfluence, what do you think about this kind of approach, before removing?

[ocean90]

+1 for do_action_deprecated().

[subrataemfluence]

Perfect! I love the idea. Still a learner :)

Replying to birgire:

There's also the ​do_action_deprecated() function introduced in 4.6:

When an action hook is deprecated, the do_action() call is replaced with do_action_deprecated(), which triggers a deprecation notice and then fires the original hook.

Similarly the ​apply_filters_deprecated() function for deprecated filters.

So in this case it might be replaced with:

do_action_deprecated( 'retreive_password', array( $user->user_login ), '1.5.1', 'retrieve_password' );

It would be interesting to scan the wordpress.org plugin repository to see if any plugin is using this deprecated filter.

@subrataemfluence, what do you think about this kind of approach, before removing?

[Mista-Flo]

It seems it was already handled by Sergey 10 months ago in #48255 so it's good we can close this ticket.

[SergeyBiryukov]

Duplicate of #48255.