![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#44332 closed enhancement (duplicate)
Hook retreive_password (depricated) should be removed
| Reported by: | subrataemfluence | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Users | Version: | 1.5.1 |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
Since the function retreive_password no longer exists in the framework any more, I think we should remove it from get_password_reset_key function. Currently it has documented as
* @deprecated 1.5.1 Misspelled. Use 'retrieve_password' hook instead.
- File: wp-includes/user.php
- Line number: 2205
Proposed patch added.
Attachments (1)
Change History (7)
#2
@
8 years ago
- Keywords needs-patch added; dev-feedback removed
- Milestone Awaiting Review → Future Release
+1 for do_action_deprecated().
#3
in reply to: ↑ 1
@
8 years ago
Perfect! I love the idea. Still a learner :)
Replying to birgire:
There's also the do_action_deprecated() function introduced in 4.6:
When an action hook is deprecated, the
do_action()call is replaced withdo_action_deprecated(), which triggers a deprecation notice and then fires the original hook.
Similarly the apply_filters_deprecated() function for deprecated filters.
So in this case it might be replaced with:
do_action_deprecated( 'retreive_password', array( $user->user_login ), '1.5.1', 'retrieve_password' );It would be interesting to scan the wordpress.org plugin repository to see if any plugin is using this deprecated filter.
@subrataemfluence, what do you think about this kind of approach, before removing?
There's also the do_action_deprecated() function introduced in 4.6:
Similarly the
apply_filters_deprecated()function.So in this case it might be replaced with:
It would be interesting to scan the wordpress.org plugin repository to see if any plugin is using this deprecated filter.
@subrataemfluence, what do you think about this kind of approach, before removing?