Emoji: Update Twemoji to 11.0

[kraftbj]

Twemoji changed versioning scheme to match Unicode. Twemoji 11 adds the Unicode/Emoji 11 new emoji.

See release notes at ​https://github.com/twitter/twemoji/releases/tag/v11.0.0

twemoji.js: ​https://github.com/twitter/twemoji/blob/v11.0.0/2/twemoji.js

Previously: #42862 , et al.

[kraftbj]

I started messing around trying to figure out how to update the various bits needed for this; sharing my work here.

• We need to add a test to check for Unicode 11 support. We could use U+1F469 U+200D U+1F9B0 (woman + ZWJ + red hair ).

Attaching a patch to bump the package.json to 11.0 and updating the CDN assets.

[kraftbj]

Bump package.json to 11.0 and change CDN to v11 assets

[peterwilsoncc]

I’ve got a jsbin I use to test the tests that might help with writing them at ​https://jsbin.com/palagay/4/edit?js,output

In the past we’ve hit a bug with skin tone modifiers returning false positives in safari that I’m worried we might hit with hair colour modifiers. I suspect it’s because they’re modifiers not intended to be displayed on their own.

Gender modifiers test correctly so is it possible to use superhero + ZWJ + a gender?

[kraftbj]

Female superhero works for me. I'm giving that a go now and will push up an updated patch shortly.

[kraftbj]

Add test for superhero+ZWJ+female

[kraftbj]

The test works for me on OS X in Chrome and Firefox, but is not catching Safari's lack of support.

[peterwilsoncc]

Failing safari test

[peterwilsoncc]

Replying to kraftbj:

The test works for me on OS X in Chrome and Firefox, but is not catching Safari's lack of support.

I can reproduce the failing test. See 44339.png​ for result in safari from ​https://jsbin.com/palagay/7/edit?js,output

I'm unsure of the cause, @pento do you have any suggestions?

[pento]

It appears that Safari attempts to render the ZWS character (8205). Removing that character from the first array fixes the test.

[kraftbj]

Thanks @pento. Attaching a version of the patch that does not include the ZWS. It works for me using Firefox Dev and Safari stock on latest OS X.

[kraftbj]

Updated test to work in Safari.

[kraftbj]

Tested via OS X in Safari, Safari TP, Chrome, Chrome Canary, Firefox, Firefox Dev, Opera, Opera Dev. Tested via Browserstack's Windows 10 client in latest version Chrome, Firefox, IE, Edge, etc. Safari for Windows squished the graphics a tad, but I don't believe that is related to this ticket.

[peterwilsoncc]

Thanks @kraftbj,

Before it can go in to core I'm assigning it to @pento for committing to the w.org CDN (apologies if you have done/can do it, I'm not up to date with meta committers).

If there is a risk s.w.org/images/core/emoji/11 has been warmed with 404s during testing, we might need to make the directory s.w.org/images/core/emoji/11.0 depending how aggressively 404s are cached.

[pento]

​Twitter is the only reliable commit notification system.

Minor note on 44339.3.diff​, you need to revert the change to package-lock.json, (maybe remove your node_modules directory) upgrade to NPM 6.1, then run npm install again, so that it creates sha512 signatures, instead of sha1.

[kraftbj]

Thanks @pento! Appreciate your patience-my first patch touching all this new build fun. I reverted, rm -rf node_modules, vvv already has 6.1 (that may have been upgraded after I did the twemoji update), and ran npm install, but it still gave me a sha1 best I can tell. It made some other changes.

Attaching what it gave me.

[kraftbj]

Fresh run of npm install

[pento]

Hrrm, that's interesting. package-lock.json can have some strange behaviour at times. 🙃

I'm not sure why it doesn't update the signature to use sha512, but 44339.5.diff​ is reasonable, I think.

I've also included the results of grunt precommit:emoji, which updates the list of HTML entities that twemoji can replace.

[pento]

In 43377:

Emoji: Update Twemoji to version 11.0.

🦹

Props kraftbj,
Fixes #44339.

[pento]

Reopen for backport, though the patch will need a refresh, due to the 4.9 branch including a copy of twemoji in src, instead of in package.json.

[kraftbj]

Patch for the 4.9 branch

[kraftbj]

Refreshed the patch for 4.9.

[netweb]

Replying to pento:

... sha512 signatures, instead of sha1.

This is typically due to cached packages locally, the npm cache has to be force cleaned to remove the old sha1's:

• npm cache clear -force

[kraftbj]

rm -rf node_nodules && npm cache clear -force && npm install didn't give me a sha512. I haven't dug into it beyond that though.

[netweb]

Replying to kraftbj:

rm -rf node_nodules && npm cache clear -force && npm install didn't give me a sha512. I haven't dug into it beyond that though.

Maybe also try deleting the package-lock.json file, at the moment this issue seems more like art than science :(

[ocean90]

4.9.7 has been released, moving to next milestone.

[kraftbj]

@netweb Do you want to give it a try on your end or do you think this is fine enough to commit as it stands?

[pento]

In 43444:

Emoji: Update Twemoji to version 11.0.

🦹

Backport of [43377] to the 4.9 branch.

Props kraftbj,
Fixes #44339.