WordPress.org

Make WordPress Core

Opened 13 days ago

Last modified 10 days ago

#44350 assigned task (blessed)

Block plugin updates if required PHP version is not supported - Updates screen

Reported by: flixos90 Owned by: afragen
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: needs-unit-tests servehappy dev-feedback has-patch
Focuses: Cc:

Description

Note: This ticket is a subtask for the overarching #40934 ticket.

When a plugin states it requires a specific minimum PHP version through its "Requires PHP" header information and the server does not support this PHP version, WordPress should block any possibility to update the plugin. This way, plugins will stay at the latest release that still supports the server's PHP version.

This ticket's goal is to prevent plugin updates from the general "Updates" admin screen. With that, it complements #43987, which deals with preventing plugins from the "Plugins" admin screen.

Attachments (4)

44350.diff (1.7 KB) - added by afragen 12 days ago.
For update-core.php
screenshot_06.png (62.3 KB) - added by afragen 12 days ago.
Checkbox gone and notice listed.
44350.2.diff (2.6 KB) - added by afragen 11 days ago.
feedback applied
screenshot_04.png (56.3 KB) - added by afragen 11 days ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #core-php by flixos90. View the logs.


13 days ago

#2 @flixos90
13 days ago

  • Owner set to afragen
  • Status changed from new to assigned

@afragen
12 days ago

For update-core.php

@afragen
12 days ago

Checkbox gone and notice listed.

#3 @afragen
12 days ago

44350.diff for removing ability to update from update-core.php page.

The following screenshot shows the checkbox missing and therefore not possible to update along with a notice regarding PHP updating.

Checkbox gone and notice listed.

#4 @afragen
12 days ago

  • Keywords dev-feedback has-patch added; needs-patch removed

Are we also looking to disable updates if the WP version is not supported?

#5 @afragen
12 days ago

The last discussion on Slack was to change the text to

This plugin doesn’t work with your version of PHP. [Learn more about updating PHP]

I’ll update the patch accordingly unless there are other suggestions.

@schlessera @flixos90 @SergeyBiryukov any other thoughts?

@afragen
11 days ago

feedback applied

@afragen
11 days ago

#6 @afragen
11 days ago

Updated patch 44350.2.diff with feedback incorporated.

Not much difference except for updating -> upgrading

This ticket was mentioned in Slack in #core-php by afragen. View the logs.


11 days ago

This ticket was mentioned in Slack in #core by afragen. View the logs.


10 days ago

Note: See TracTickets for help on using tickets.