Update PHPCS ruleset for WP Core and related Composer setup

[jrf]

This update the core native PHPCS ruleset

.gitignore:

• Add the typical filenames of overloaded PHPCS configs to .gitignore.

Composer:

• Use the develop (Packagist dev-master) version of WPCS as it contains lots of bugfixes.
• Remove the PHPCS dependency. This is a dependency of WPCS, not of WP Core itself. This will also make sure that the PHPCS version used is always one which is supported by WPCS.
• Refreshed the composer.lock file.

PHPCS ruleset:

• Comment out a reference to a sniff which doesn't exist in WPCS yet (for now).
• Use the PHPCS 3.x basepath option to clean up the file paths PHPCS shows in the reports.
• Use the PHPCS 3.x parallel option to enable parallel scanning whenever possible to speed up the scans.
• Whitelist the wp-includes/I18n.php file from issues being reported by the WordPress.WP.I18n sniff.

[jrf]

In 43348:

Build/Tools: Update PHPCS ruleset for WP Core and related Composer setup.

.gitignore + svn:ignore:

• Add the typical filenames of overloaded PHPCS configs to .gitignore.

Composer:

• Use the develop (Packagist dev-master) version of WPCS as it contains lots of bugfixes.
• Remove the PHPCS dependency. This is a dependency of WPCS, not of WP Core itself. This will also make sure that the PHPCS version used is always one which is supported by WPCS.
• Refreshed the composer.lock file.

PHPCS ruleset:

• Removed a reference to a sniff which doesn't exist in WPCS yet.
• Use the PHPCS 3.x basepath option to clean up the file paths PHPCS shows in the reports.
• Use the PHPCS 3.x parallel option to enable parallel scanning whenever possible to speed up the scans.
• Whitelist the wp-includes/l10n.php file from issues being reported by the WordPress.WP.I18n sniff.

Fixes #44366.

[GaryJ]

Use the develop (Packagist dev-master) version of WPCS as it contains lots of bugfixes.

The composer.lock is showing that this is now pointing to ​https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/commit/cf6b310caad735816caef7573295f8a534374706 which is the 0.14.1 release.

Was this intended, or should it have been the dev-develop branch (​https://packagist.org/packages/wp-coding-standards/wpcs#dev-develop)?

[GaryJ]

Also, there appears to be a typo: "simultanously" should be "simultaneously"

[netweb]

As part of adding PHPCS to the 5.0 branch reopening and moving back to the 5.0 milestone

[netweb]

Patch 44366-50branch.diff​ for the 5.0 branch is ready for commit

Note: The patch includes the changes for svn:ignore, highly unlikely it will applied when applying the patch though.

To edit svn:ignore run svn propedit svn:ignore . from the command line and add phpcs.xml and .phpcs.xml after phpunit.xml

Index: .
===================================================================
--- .   (revision 43735)
+++ .   (working copy)

Property changes on: .
___________________________________________________________________
Modified: svn:ignore
## -5,9 +5,11 ##

 # Files and folders related to build/test tools
 phpunit.xml
+phpcs.xml
+.phpcs.xml
 node_modules
 npm-debug.log
 build
 wp-cli.local.yml
 .git
 jsdoc

[netweb]

Patch 44366-50branch.diff​ is based on [43348] for backporting to the 5.0 branch

It also includes recent phpcs.xml.dist changes from:

• [42346] / #41057
• [43013] / #43776
• [43571] / #44600
• [43641] / #44896
• [43655] / #41333

It also includes recent composer.json/composer-lock.json changes from:

• [42960],[42691] / #43558
• [43571] / #44600

I've not re-opened the above 6 tickets for the 5.0 milestone, committers choice to reference these during commit

[pento]

In 43786:

Build/Tools: Add PHPCS to the 5.0 branch.

This allows us to apply WordPress Coding Standards rules to new files in the 5.0 branch.

Props netweb.
Fixes #44366.

[ocean90]

In 44507:

Build/Tools: Fix typo in phpcs.xml.dist.

See #44366.