WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#44369 closed enhancement (wontfix)

Apply PHPCS coding standards to Cookie.php

Reported by: subrataemfluence's profile subrataemfluence Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch
Focuses: coding-standards Cc:

Description

/src/wp-includes/Requests/Cookie-patched.php has lot of coding standards issues.

Uploaded proposed patch.

Attachments (1)

44369.diff​ (14.8 KB) - added by subrataemfluence 7 years ago.

Download all attachments as: .zip

Change History (6)

@subrataemfluence
7 years ago

#1 @subrataemfluence
7 years ago

  • Keywords has-patch added; needs-patch removed

#2 @pento
6 years ago

  • Version trunk deleted

#3 follow-up: @sabernhardt
5 years ago

  • Keywords needs-refresh added

@subrataemfluence I wasn't able to apply this patch. Would you mind updating it?

(Or if you prefer, I could try to match the changes, and then you could check if I missed something.)

#4 in reply to: ↑ 3 @subrataemfluence
5 years ago

Thank you very much for checking in. Please feel free to make the necessary changes.

Replying to sabernhardt:

@subrataemfluence I wasn't able to apply this patch. Would you mind updating it?

(Or if you prefer, I could try to match the changes, and then you could check if I missed something.)

#5 @SergeyBiryukov
5 years ago

  • Component changed from General to External Libraries
  • Keywords needs-refresh removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hi there, thanks for the patch.

Requests is an external library and doesn't really have to follow WordPress coding standards. Any suggested changes would need to be submitted upstream: ​https://github.com/rmccue/Requests.

Note: See TracTickets for help on using tickets.