Make sure all JS globals are explicitly assigned to the window.

[omarreiss]

Currently there are a lot of variables in the JavaScript that are being defined in the global scope without being explicitly assigned to the window. When we start using Webpack to build all the JavaScript, the code will get encapsulated in an anonymous function and those implicit globals could get assigned to a different scope. To make sure that doesn't happen, I've created a patch to make sure all globals are explicitly assigned to the window.

[pento]

Let's get this in.

All of these globals appear to be intended to be globally scoped: they're all declared outside the functions where they're used later in the files.

[omarreiss]

Patch updated, went through everything again, found one more implicit global. Plan on committing this today.

[pento]

🕺🏻

[omarreiss]

Explicitly referencing globals on the window is not in scope for this ticket.

[omarreiss]

In 43577:

General: Explicitly assigns all JS globals to the window.

Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

[azaozz]

[43577] broke quicktags.js. Also some of the changes there don't seem to make much sense, especially for a very very VERY old lib like QuickTags :)

[azaozz]

In 43579:

Reorder quicktags.js a bit to account for the order of defining vars and functions after [43577].

See #44371.

[pento]

@azaozz: Was [43579] the only change that needed to happen here?

[azaozz]

Replying to pento:

@azaozz: Was [43579] the only change that needed to happen here?

Yeah, assigning of the functions to vars in [43577] broke the order in quicktags.js a bit. The rest seems to be working.

Paste this in the console:

test();
function test() {
 console.log(1);
}
// 1

window.test2();
window.test2 = function() {
 console.log(2);
}
// ReferenceError: test2 is not defined.

[pento]

🕺🏻