WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#44380 closed defect (bug) (duplicate)

The two instances of user_confirmed_action_email_content should be unique

Reported by: garrett-eclipse Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Privacy Keywords:
Focuses: privacy Cc:

Description

Hello,

I noticed that the user_confirmed_action_email_content filter is used in two places will fully different contents expected and feel they should be unique to avoid accidentally affected the other instance unintentionally.

They can be found here;
https://github.com/WordPress/WordPress/blob/3ee58b55b14683af4c568bce1845c37408c88fbb/wp-includes/user.php#L3054
https://github.com/WordPress/WordPress/blob/3ee58b55b14683af4c568bce1845c37408c88fbb/wp-includes/user.php#L3172

The biggest difference I noticed was the $email_data and placeholders are all different between each instance.

Cheers

Change History (3)

#1 @desrosj
13 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version trunk deleted

Good find, @garrett-eclipse. This is already being tracked in #44314. Patch testing is appreciated!

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


13 months ago

#3 @garrett-eclipse
13 months ago

Thanks @desrosj I'll check it out

Note: See TracTickets for help on using tickets.