Several importers use add_option "wrong"

[Nazgul]

The dotclear and textpattern importers pass incorrect arguments to add_option.

Function signature:

function add_option($name, $value = '', $description= '', $autoload = 'yes')

Usage (pseudocode):

add_option('option', $value, true));

So they're passing true to the description parameter, which isn't quite usefull. On the other hand, passing true to autoload also won't work, because it has an implicit check for the string 'yes', which would fail.

I don't have much experience with the importers and therefore don't know what the intended behaviour is and therefore don't know how to fix this. I just noticed this stange behaviour while working on another ticket.

[markjaquith]

We may deprecate the description (see #4398)

$autoload needs to be re-worked so that only 'yes' and 'no' are possible.

[markjaquith]

(In [5686]) Force $autoload to be either "yes" or "no". see #4440. props Nazgul

[markjaquith]

Now anything without explicit 'no' will be 'yes,' but the importers should still be patched so that they give a good example.

[Nazgul]

I need to learn to count brackets. :(

The true isn't passed as the description, but as the second argument to sanitize_user.

At least the patch by markjaquith made the code somewhat more robust. :)