WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 4 weeks ago

#44410 new defect (bug)

Properties in class missing type definition and description in DOC comments

Reported by: subrataemfluence Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version: trunk
Component: Customize Keywords: has-patch
Focuses: coding-standards Cc:

Description

Doc comment section is missing for declared public properties.

  • File: src/wp-includes/customize/class-wp-customize-header-image-control.php
class WP_Customize_Header_Image_Control extends WP_Customize_Image_Control {
  public $type = 'header';
  public $uploaded_headers;
  public $default_headers;
  ...
}

Can the proposed patch help?

Attachments (4)

44410.diff (699 bytes) - added by subrataemfluence 5 weeks ago.
44410-2.diff (700 bytes) - added by subrataemfluence 5 weeks ago.
44410-3.diff (754 bytes) - added by subrataemfluence 4 weeks ago.
44410-4.diff (754 bytes) - added by subrataemfluence 4 weeks ago.

Download all attachments as: .zip

Change History (10)

#1 @GaryJ
5 weeks ago

The middle DocBlock description is missing a full stop.

#2 @subrataemfluence
5 weeks ago

Thank you @GaryJ for pointing out the mistake :) Uploaded a fix.

#3 @westonruter
5 weeks ago

The phpdoc should include the @since tags.

#4 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 5.0

#5 @subrataemfluence
4 weeks ago

Thank you @westonruter ! I have uploaded the modified patch. Hope this is OK now.

#6 @subrataemfluence
4 weeks ago

Silly mistake with @since version.

Note: See TracTickets for help on using tickets.