WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44427, comment 31


Ignore:
Timestamp:
08/17/2019 02:58:58 PM (6 months ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44427, comment 31

    initial v1  
    3939Not all af these might be part of the content, but I wonder how mixing it with {{{loading="lazy"}}} will affect the already lazy loaded content images.
    4040
    41 If they can't mix, then more aggressive checks come to mind to avoid it. Rather than checking only for the {{{' lazy="'}}} as in [attachment:"44427.2.diff"], one could avoid replacements on images that contain {{{data}}} attributes for original, src, lazy, lazy-src, source, ... etc. But I think that might still miss out lot of other cases. (filterable?)
     41If they can't mix, then more aggressive checks come to mind to avoid it. Rather than checking only for the {{{' loading='}}} as in [attachment:"44427.2.diff"], one could avoid replacements on images that contain {{{data}}} attributes for original, src, lazy, lazy-src, source, ... etc. But I think that might still miss out lot of other cases. (filterable?)
    4242
    4343Making the flag available to themes, rather than having it ON by default, sounds safer, at least to start with.