WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #44427, comment 71


Ignore:
Timestamp:
01/03/2020 07:19:34 PM (6 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44427, comment 71

    v2 v3  
    55> I think this should be back-ported to all content because only then it will have a significant impact on performance of WordPress websites.
    66
    7 Yep, I agree this will have the highest/best impact.
     7Right, this will have the highest/best impact. Lets do it.
    88
    99> I think the impact of one `preg_replace_callback()` per post is rather low on a relative scale - the logic for adding `loading` attributes is much cheaper than e.g. the one for making images responsive, it includes much less logic and no potential database call. Maybe we can optimize the patch further though, particularly the additional `preg_match()` that runs for every match/image.
     
    2121> I don't think we should expand this ticket further to cover adding these attributes too (`importance` and `decoding`), but whether their combination can have unintended effects is crucial to know.
    2222
    23 Yes, completely agree. These two attribute seem very specific anyway, don't think we can auto-add them even if we wanted to, and seems they shouldn't be removed when present.
     23Yes, these two attribute seem very specific anyway, don't think we can auto-add them even if we wanted to, and seems they shouldn't be removed when present.