WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#44436 closed defect (bug) (invalid)

Incompatibility of WordPress basic coding standards.

Reported by: subrataemfluence's profile subrataemfluence Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: coding-standards Cc:

Description

File name: src/wp-includes/random_compat/byte_safe_strings.php

Above file is heavily missing basic WordPress coding standards rules.
Proposed patch added.

Attachments (1)

44436.diff​ (8.7 KB) - added by subrataemfluence 7 years ago.

Download all attachments as: .zip

Change History (3)

@subrataemfluence
7 years ago

#1 @ocean90
7 years ago

  • Keywords needs-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Version trunk deleted

Hello @subrataemfluence, thanks for your patch.

random_compat is a third-party library (​https://github.com/paragonie/random_compat) thus we do not change the files. It's also excluded in the PHPCS ruleset, see https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist?rev=43348&marks=48#L31.

#2 @subrataemfluence
7 years ago

Thank you for letting me know and close the ticket!

Note: See TracTickets for help on using tickets.