Have a method to check if a taxonomy is viewable

[andizer]

I was in need of a function that checks if a given taxonomy is viewable. In WordPress there is already a similar function to check this for a post type (is_post_type_viewable).

I think it would be useful to have this for taxonomies as well. Like is_taxonomy_viewable

[flixos90]

This makes complete sense to me, for both parity and solving a common use-case universally. Let's introduce is_taxonomy_viewable().

This should be an easy thing, before we implement it though, I'm wondering about is_post_type_viewable(): Why does it use $public for built-in post types and $publicly_queryable for all the others? I feel like it would make more sense if it only looked at $publicly_queryable in all cases.

[SergeyBiryukov]

Replying to flixos90:

I'm wondering about is_post_type_viewable(): Why does it use $public for built-in post types and $publicly_queryable for all the others?

Because publicly_queryable is false for pages, but they're still considered viewable. See [33666] and [18234] for some more context.

[flixos90]

Thanks for the patch @andizer!

I think two small changes are needed:

• For taxonomies, we only need to check publicly_queryable in any case. The only reason is_post_type_viewable() contains the extra logic is because of the special case of pages being public but not publicly queryable. This doesn't exist for taxonomies in core, so we can simplify here.
• We don't need the isset() checks as these properties always are set on taxonomy objects.

Let me know if you wanna work on unit tests for this as well. For now I'll assign it to you for further iteration.

[andizer]

Implements the function where possible

[flixos90]

In 44466.2.diff​ I assembled the previous patches into one. Everything worked perfectly, I just made a few changes:

• Got rid of the one usage in the REST API controller. While it technically works, that code is getting values for taxonomy properties, so publicly_queryable should continue to simply get its value.
• Added 5.0.0 version number to the function.
• Added missing call to parent setUp() method in the test class.

[flixos90]

In 43386:

Taxonomy: Introduce is_taxonomy_viewable().

This utility function allows for easy detection whether terms for a taxonomy are considered publicly viewable.

Props andizer.
Fixes #44466.

[johnbillion]

@since needs updating

[andizer]

Updated the @since

[andizer]

@johnbillion I've just updated the patch

[pento]

In 44447:

Docs: Update @since for is_taxonomy_viewable().

Props andizer.
Fixes #44466.