WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44475, comment 2


Ignore:
Timestamp:
08/16/2018 09:57:39 PM (3 years ago)
Author:
aubreypwd
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44475, comment 2

    initial v1  
    1 This was a little dismissive. I'm not questioning if documentation is wrong or write, I'm saying that the expectation behind this function is misleading and inefficient. I would expect if I passed a function called `wp_trim_excerpt` some text it would trim what I sent it, or it would always, at least, return a trimmed something. Why pass text to a function that simply returns it back to me? It just makes no sense.
     1This was a little dismissive. I'm not questioning if documentation is wrong or right, I'm saying that the expectation behind this function is misleading and inefficient. I would expect if I passed a function called `wp_trim_excerpt` some text it would trim what I sent it, or it would always, at least, return a trimmed something. Why pass text to a function that simply returns it back to me? It just makes no sense.
    22
    33Maybe it should return the generated text (trimmed) and the parameter should be deprecated since it does nothing except filter it.