Opened 3 years ago
Closed 2 years ago
#44479 closed defect (bug) (worksforme)
Twenty Seventeen: Video header issues
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | critical | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
I have run into a problem with 2017 theme. I put a video in the header and when I do I loose all the picture posts on the front page except for Home page. When I remove the video they come back. Plus it was very difficult to remove the video. I had to do a hack to remove it.
stephenstefanski2@…
Attachments (2)
Change History (10)
#1
follow-up:
↓ 2
@
3 years ago
- Component changed from General to Bundled Theme
- Summary changed from Video header 2017 theme to Twenty Seventeen: Video header issues
#3
@
3 years ago
Hi @stansk1954 - thanks for reporting this!
I think I'm seeing the same issue that you're describing. For me it's only happening in Chrome (the site looks fine in Firefox); the first image is kind of cut off, and the others are totally gone.
Partially gone:
Totally gone:
These screenshots are from http://2017.wordpress.net/.
Is this the same as what you're seeing?
If it is not the same issue, can you please include a screenshot of what you're seeing on your site when you add a header video?
Thanks!
#4
@
3 years ago
- Keywords has-patch added
I've gone ahead with a patch for this, because I'm pretty sure we're talking about the same thing (@stansk1954, please let me know if that's not the case!).
It looks like this is somehow related to a recent Chrome update.
44479.patch includes a CSS fix suggested here: https://stackoverflow.com/questions/50804554/css-background-attachment-fixed-fix-for-chrome-67
I don't really get why it's only happening when the video is enabled, though; the CSS for .panel-image
isn't changed in that case.
#5
@
3 years ago
I belatedly realized my first patch caused issues in Firefox (the featured images no longer remain fixed, losing the faux-parallax effect). 44479.2.patch uses a different approach that doesn't cause that same problem.
#8
@
2 years ago
- Keywords needs-testing removed
- Milestone Future Release deleted
- Resolution set to worksforme
- Status changed from assigned to closed
It appears that this issue may have resolved itself, as I don't see any of the described issues in Chrome or Firefox. @stansk1954 feel free to reopen this if you are still having issues.
Replying to SergeyBiryukov:
I am not sure what your answer is.