Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#44502 closed defect (bug) (fixed)

@access private tag is missing for some private functions

Reported by: shamim51's profile shamim51 Owned by: shamim51's profile shamim51
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Posts, Post Types Keywords: has-patch good-first-bug
Focuses: docs Cc:

Description

in wp-includes/post.php @access private tag is missing for some of the private functions.

Attachments (2)

44502.patch (951 bytes) - added by shamim51 6 years ago.
44502-2.patch (987 bytes) - added by shamim51 6 years ago.

Download all attachments as: .zip

Change History (12)

@shamim51
6 years ago

#1 @shamim51
6 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #docs by shamim51. View the logs.


6 years ago

#3 @netweb
6 years ago

  • Milestone changed from Awaiting Review to 5.0

#4 @desrosj
6 years ago

  • Keywords good-first-bug needs-refresh added

Tagging as good-first-bug and assigning to mark claimed.

@shamim51 thanks for the ticket and patch! It looks like you found all of the missing tags, but there is one issue with your patch. Patches should be against the root directory of a WordPress checkout. Are you able to refresh the patch? The Core Handbook has some useful information on creating patches.

@shamim51
6 years ago

#5 @shamim51
6 years ago

  • Keywords needs-refresh removed

#6 @shamim51
6 years ago

@desrosj thanks.
I have uploaded refresh patch against the root directory. Let me know if it is ok.

#7 @peterwilsoncc
6 years ago

  • Milestone changed from 5.0 to 5.1

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

#8 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44636:

Docs: Mark the internal functions as @private in wp-includes/post.php.

Props shamim51.
Fixes #44502.

#9 @pento
5 years ago

In 44638:

Docs: Partial revert of [44636].

Unrelated changes in wp-includes/general-template.php were accidentally committed.

See #44502.

This ticket was mentioned in Slack in #core-docs by shamim51. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.