#44512 closed feature request (fixed)
Add $error argument to lost_password action
Reported by: | wonderyan | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Login and Registration | Keywords: | has-patch |
Focuses: | Cc: |
Description
I'm trying to hook login process to display my own forms and in wp-login.php for lostpassword case the action lost_password is fired just before displaying the corresponding form.
It would be very usefull that this action fires with $errors as arguments as it could have errors of type invalidkey & expiredkey ?
Attachments (2)
Change History (17)
#2
@
6 years ago
- Keywords has-patch added; needs-patch removed
- Resolution set to worksforme
- Status changed from new to closed
Added $error parameter in lost_password action.
#3
@
6 years ago
- Milestone changed from Awaiting Review to 5.0
- Resolution worksforme deleted
- Status changed from closed to reopened
@sebakurzyn
Thanks for the patch!
It can be a little confusing but we use the resolution and status to indicate whether a ticket a patch has been committed to the code base. Marking it worksforme
closes the ticket and indicates the decision has been made not to commit it.
I've reopened this ticket to make sure it appears in searches for tickets that are going to be committed to the project.
I'll also refer you to the WordPress PHP Coding standards. There are a few things in the patch that need to be reformatted but they can be fixed by the person who commits the code.
#4
@
6 years ago
Thanks a lot for answer and help. I will check the coding standards. So next time I should simply add the patch and don't change a ticket status? Am I right? :)
#5
@
6 years ago
@sebakurzyn that's correct, adding the has-patch
keyword (as you did) is helpful too.
#7
@
6 years ago
- Owner set to johnbillion
- Resolution set to fixed
- Status changed from reopened to closed
In 43542:
#8
@
6 years ago
- Keywords good-first-bug removed
- Milestone changed from 5.0 to 5.0.1
- Resolution fixed deleted
- Status changed from closed to reopened
Hey guys! I added $error parameter and docs.