WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#44512 closed feature request (fixed)

Add $error argument to lost_password action

Reported by: wonderyan Owned by: johnbillion
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch
Focuses: Cc:

Description

I'm trying to hook login process to display my own forms and in wp-login.php for lostpassword case the action lost_password is fired just before displaying the corresponding form.

It would be very usefull that this action fires with $errors as arguments as it could have errors of type invalidkey & expiredkey ?

Attachments (2)

patch.diff (918 bytes) - added by sebakurzyn 3 years ago.
Hey guys! I added $error parameter and docs.
44512.2.diff (537 bytes) - added by audrasjb 2 years ago.
@since refresh for 5.0.3

Download all attachments as: .zip

Change History (17)

#1 @johnbillion
3 years ago

  • Keywords needs-patch good-first-bug added
  • Version 4.9.6 deleted

@sebakurzyn
3 years ago

Hey guys! I added $error parameter and docs.

#2 @sebakurzyn
3 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolution set to worksforme
  • Status changed from new to closed

Added $error parameter in lost_password action.

#3 @peterwilsoncc
3 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Resolution worksforme deleted
  • Status changed from closed to reopened

@sebakurzyn

Thanks for the patch!

It can be a little confusing but we use the resolution and status to indicate whether a ticket a patch has been committed to the code base. Marking it worksforme closes the ticket and indicates the decision has been made not to commit it.

I've reopened this ticket to make sure it appears in searches for tickets that are going to be committed to the project.

I'll also refer you to the WordPress PHP Coding standards. There are a few things in the patch that need to be reformatted but they can be fixed by the person who commits the code.

#4 @sebakurzyn
3 years ago

Thanks a lot for answer and help. I will check the coding standards. So next time I should simply add the patch and don't change a ticket status? Am I right? :)

#5 @peterwilsoncc
3 years ago

@sebakurzyn that's correct, adding the has-patch keyword (as you did) is helpful too.

#6 @wonderyan
3 years ago

Thanks for your considerations

#7 @johnbillion
3 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from reopened to closed

In 43542:

Login and Registration: Pass the $errors parameter to the lost_password action.

Props sebakurzyn

Fixes #44512

#8 @johnbillion
2 years ago

  • Keywords good-first-bug removed
  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @desrosj
2 years ago

This @since tag needs to be changed to 5.0.1.

#10 @pento
2 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#11 @pento
2 years ago

  • Milestone changed from 5.0.2 to 5.0.3

@audrasjb
2 years ago

@since refresh for 5.0.3

#12 @audrasjb
2 years ago

  • Keywords commit added

Hi,

44512.2.diff adds @since refresh for 5.0.3.

#13 @desrosj
2 years ago

  • Milestone changed from 5.0.3 to 5.1

Let's leave this in the 5.1 release as it is outside of the 5.0.3 scope. The @since just needs to be updated to 5.1.0.

#14 @desrosj
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44396:

Docs: Update since annotation for new lost_password action parameter.

Introduced in [43542].

Fixes #44512.

#15 @desrosj
2 years ago

  • Keywords commit removed
Note: See TracTickets for help on using tickets.