Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#44512 closed feature request (fixed)

Add $error argument to lost_password action

Reported by: wonderyan Owned by: johnbillion
Priority: normal Milestone: 5.1
Component: Login and Registration Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

I'm trying to hook login process to display my own forms and in wp-login.php for lostpassword case the action lost_password is fired just before displaying the corresponding form.

It would be very usefull that this action fires with $errors as arguments as it could have errors of type invalidkey & expiredkey ?

Attachments (2)

patch.diff (918 bytes ) - added by sebakurzyn 8 years ago.
Hey guys! I added $error parameter and docs.
44512.2.diff (537 bytes ) - added by audrasjb 8 years ago.
@since refresh for 5.0.3

Download all attachments as: .zip

Change History (17)

#1 @johnbillion
8 years ago

  • Keywords needs-patch good-first-bug added
  • Version 4.9.6

@sebakurzyn
8 years ago

Hey guys! I added $error parameter and docs.

#2 @sebakurzyn
8 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolutionworksforme
  • Status newclosed

Added $error parameter in lost_password action.

#3 @peterwilsoncc
8 years ago

  • Milestone Awaiting Review5.0
  • Resolution worksforme
  • Status closedreopened

@sebakurzyn

Thanks for the patch!

It can be a little confusing but we use the resolution and status to indicate whether a ticket a patch has been committed to the code base. Marking it worksforme closes the ticket and indicates the decision has been made not to commit it.

I've reopened this ticket to make sure it appears in searches for tickets that are going to be committed to the project.

I'll also refer you to the WordPress PHP Coding standards. There are a few things in the patch that need to be reformatted but they can be fixed by the person who commits the code.

#4 @sebakurzyn
8 years ago

Thanks a lot for answer and help. I will check the coding standards. So next time I should simply add the patch and don't change a ticket status? Am I right? :)

#5 @peterwilsoncc
8 years ago

@sebakurzyn that's correct, adding the has-patch keyword (as you did) is helpful too.

#6 @wonderyan
8 years ago

Thanks for your considerations

#7 @johnbillion
8 years ago

  • Owner set to johnbillion
  • Resolutionfixed
  • Status reopenedclosed

In 43542:

Login and Registration: Pass the $errors parameter to the lost_password action.

Props sebakurzyn

Fixes #44512

#8 @johnbillion
8 years ago

  • Keywords good-first-bug removed
  • Milestone 5.05.0.1
  • Resolution fixed
  • Status closedreopened

#9 @desrosj
8 years ago

This @since tag needs to be changed to 5.0.1.

#10 @pento
8 years ago

  • Milestone 5.0.15.0.2

#11 @pento
8 years ago

  • Milestone 5.0.25.0.3

@audrasjb
8 years ago

@since refresh for 5.0.3

#12 @audrasjb
8 years ago

  • Keywords commit added

Hi,

44512.2.diff adds @since refresh for 5.0.3.

#13 @desrosj
8 years ago

  • Milestone 5.0.35.1

Let's leave this in the 5.1 release as it is outside of the 5.0.3 scope. The @since just needs to be updated to 5.1.0.

#14 @desrosj
8 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 44396:

Docs: Update since annotation for new lost_password action parameter.

Introduced in [43542].

Fixes #44512.

#15 @desrosj
8 years ago

  • Keywords commit removed
Note: See TracTickets for help on using tickets.