#4452 closed defect (bug) (fixed)
wpx can include invalid named entities in comment author name
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.2.2 | Priority: | normal |
Severity: | normal | Version: | 2.2.1 |
Component: | Administration | Keywords: | |
Focuses: | Cc: |
Description
Hi,
WP's xml export doesn't currently escape the conents of many fields, including the comment author. If those fields include named HTML entities, that means it's invalid XML. The importer handles it just fine, but some browsers will complain with an error or refuse to download the export file if the XML doesn't validate.
Attached is an example of the problem output, and a patch that uses CDATA escaping on the comment author field. Other fields could be escaped too, but I've limited the change to the one that I've seen cause a problem in the wild.
On the import side, get_tag() will accept CDATA on any field now. It should retain backwards compatibility with export files created prior to this patch.
Attachments (3)
Change History (15)
#4
@
16 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Committed for 2.3. Let's see how it handles and then schedule it for 2.2.2.
@
16 years ago
tellyworth found a problem, this fix from tellyworth fixes the problem importing post body
#6
@
16 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
- Version set to 2.2.1
Re-open, currently only fixed on trunk.
#7
@
16 years ago
I am not sure whether this should go on the same ticket or a different one, but the comment content is another field that might contain entities. As of [5744], if you add a comment to a post with an entity, such as é or ñ (common in Spanish for accents), your XML export file will not validate, as described in this bug report. So probably the wp:comment field in the export needs to be escaped with CDATA too.
#9
@
16 years ago
Marked #4684 a duplicate, can we get this checked into the 2.2 branch, because current WordPress.com exports imported into 2.2.1 are broken b/c of this fix to trunk.
Looks okay to me.