Opened 7 years ago
Closed 6 years ago
#44521 closed enhancement (fixed)
Add documentation to the PHPUnit factory objects
Reported by: | andizer | Owned by: | pento |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
I discovered that the php unit test factories for WordPress aren't documented well. To make it easier for every one I decided to add some documentation for it.
Another thing I was wondering about is the old php4 way to declare methods (without access modifiers) and var declarations on class attributes. Is it desirable to modernize these or should I keep this untouched. Probably it is worth to make a separate issue for it.
Attachments (2)
Change History (8)
Note: See
TracTickets for help on using
tickets.
@andizer
One thing I noticed when doing a quick skim of your patch: The docblock for
WP_UnitTest_Factory_Callback_After_Create::__construct()
hasstring
as the parameter type. This should actually becallable
. While this type hint is only valid in PHP 5.4+, using it in the docblock won't have any issue.