WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#44545 closed defect (bug) (fixed)

Commented out code in admin-filters.php

Reported by: dilipbheda's profile dilipbheda Owned by: girishpanchal's profile Girishpanchal
Milestone: 5.1 Priority: low
Severity: normal Version: 3.8
Component: General Keywords: has-patch good-first-bug commit
Focuses: administration Cc:

Description (last modified by swissspidy)

I found commented out code in admin-filters.php.

These actions are no longer available anywhere.

As consider coding standards we should remove the unused actions from the file.

Attachments (1)

44545.patch​ (858 bytes) - added by Girishpanchal 7 years ago.
Here is the patch where i have removed these commits.

Download all attachments as: .zip

Change History (6)

@Girishpanchal
7 years ago

Here is the patch where i have removed these commits.

#1 @Girishpanchal
7 years ago

  • Keywords has-patch added

#2 @swissspidy
7 years ago

  • Description modified (diff)
  • Focuses coding-standards removed
  • Milestone changed from Awaiting Review to 5.0
  • Priority changed from normal to low
  • Summary changed from Found add_action committing code on admin-filters.php to Commented out code in admin-filters.php
  • Version trunk deleted

#3 @desrosj
7 years ago

  • Focuses administration added; docs removed
  • Keywords good-first-bug commit added
  • Owner set to Girishpanchal
  • Status changed from new to assigned
  • Version set to 3.8

Thanks for the ticket, @dilipbheda!

I did some digging to find out why these were commented out, and if there was a reason they were left in the codebase.

These action hooks appear to be remnants of the old theme installing experience that was removed in 3.9 in favor of the ​theme viewing experience introduced in 3.8 (THX). They were commented out in [27499] as a part of #27055 and later moved into admin-filters.php in [32653] as a part of #32529, but there was no obvious reason why they remained in the codebase.

These should be safe to remove, but the above details should be mentioned in the commit for historical context.

#4 @peterwilsoncc
7 years ago

  • Milestone changed from 5.0 to 5.1

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

#5 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44647:

Coding Standards: Remove some add_action()s that were commented out years ago.

Props Girishpanchal.
Fixes #44545.

Note: See TracTickets for help on using tickets.