WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44550, comment 3


Ignore:
Timestamp:
08/14/2018 03:56:14 PM (2 years ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44550, comment 3

    initial v1  
    1 [attachment:"44550.1.diff"] is a different approach that I like better. It utilizes code already in `wp-login.php` that detects the `wp_lang` URL parameter. This is utilized for all of the other screens (password reset, password change, log out, etc.) on `wp-login.php`. It also uses `restore_previous_locale()` instead of `restore_current_locale()`. The latter restores the original locale and removes any switching history, but the former only reverts the most recent switch.
     1[attachment:"44550.2.diff"] is a different approach that I like better. It utilizes code already in `wp-login.php` that detects the `wp_lang` URL parameter. This is utilized for all of the other screens (password reset, password change, log out, etc.) on `wp-login.php`. It also uses `restore_previous_locale()` instead of `restore_current_locale()`. The latter restores the original locale and removes any switching history, but the former only reverts the most recent switch.
    22
    33Tests for this need to be added after or as a part of #43985 (depending which is committed first), as that ticket adds tests for the entire `wp_send_user_request()` function.