Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#44557 closed feature request (fixed)

Add support for Instagram TV

Reported by: dannydehaan's profile dannydehaan Owned by: pento's profile pento
Milestone: 5.1 Priority: normal
Severity: minor Version: 5.1
Component: Embeds Keywords: has-patch needs-docs
Focuses: Cc:

Description

WordPress now only provides support for IG images. I would like IG TV support too. My colleague's were also asking for it.

Attachments (2)

44557-Support-for-Instagram-TV.patch (1.3 KB) - added by dannydehaan 5 years ago.
Patch file for 44557
44557-Added-Instagram-TV-to-the-current-regex.patch (1.4 KB) - added by dannydehaan 5 years ago.
Added tv to the current regex

Download all attachments as: .zip

Change History (14)

@dannydehaan
5 years ago

Patch file for 44557

#1 @netweb
5 years ago

  • Milestone changed from Awaiting Review to 5.0

#2 @swissspidy
5 years ago

Looks like we can just add it to the existing regex.

@dannydehaan
5 years ago

Added tv to the current regex

#3 @pento
5 years ago

  • Milestone changed from 5.0 to 5.1

#4 @swissspidy
5 years ago

  • Keywords needs-docs added

#5 @desrosj
5 years ago

@dannydehaan are you able to refresh the patch and mention the new support in the oembed_providers filter documentation?

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


5 years ago

#7 @pento
5 years ago

  • Owner set to pento
  • Status changed from new to assigned

#8 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44486:

Embeds: Add Instagram TV support.

Props dannydehaan.
Fixes #44557.

#9 @joemcgill
5 years ago

@pento in my testing earlier today, I couldn't get this to work. Did you confirm this endpoint does the task?

#10 @pento
5 years ago

Yah, it seems to work for me. I was able to embed https://www.instagram.com/tv/BkQjCfsBIzi/ in a post.

#11 @desrosj
5 years ago

Were you using Firefox, by chance, @joemcgill?

#12 @joemcgill
5 years ago

Probably forgot to grunt build or something. Cools!

Note: See TracTickets for help on using tickets.