WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers

[antonypuckey]

This commit: ​https://github.com/WordPress/WordPress/commit/c9dce0606b0d7e6f494d4abe7b193ac046a322cd breaks plugins that save media to external systems via stream wrappers.

The underlying cause of this is realpath() does not accept a stream url as valid path and always returns false.

Im not that familiar with wordpress yet but I have created a patch that fixes the problem which i have attached.

[antonypuckey]

Patch to allow stream wrapper urls to be deleted.

[antonypuckey]

The side effect of not using this patch is the files that are deleted from wordpress are orhpaned in the remote location and will never be deleted.

[johnbillion]

Thank you very much for this report, @antonypuckey!

Moving this into the 4.9.8 milestone for investigation.

[pento]

4.9.8 is in RC, moving to 4.9.9.

[l3rady]

related #44706 and #39476

[joemcgill]

@l3rady are you able to test the proposed patch wordpress-4.9.7-delete-media-streamwrapper.patch​ and confirm that this would fix the issue for you?

[pfiled]

@joemcgill I'm not l3rady, but I am having this issue with s3-uploads as well. I am out of the office over the holiday weekend here in the US, but will be happy to test it thoroughly on Tuesday.

[joemcgill]

Replying to pfiled:

@joemcgill I'm not l3rady, but I am having this issue with s3-uploads as well. I am out of the office over the holiday weekend here in the US, but will be happy to test it thoroughly on Tuesday.

Thanks @pfiled. That would be terrific.

[pfiled]

Hi @joemcgill we tested this, and while it removes the original media file, thumbnails are not being removed from S3. Rolling core back to 4.9.6 causes thumbnails to be removed as expected.

I'm in #core-media on slack and happy to test any other changes you suggest.

[pento]

#44706 was marked as a duplicate.

[shadyshane]

I encountered the same problem. The reason why S3-Uploads did not work with @antonypuckey 's patch is the WordPress is no longer pass the absolute path to wp_delete_file filter.

S3-Uploads compatible fix for this patch is here ​https://github.com/nhanledev/S3-Uploads/commit/e19b75629d91113f41cf9ed2fed85ab8b8fb0dd3

[pfiled]

@joemcgill Following up on this, I can can confirm that patch @shadyshane provided for s3-uploads combined with this patch does solve this issue.

If it's possible, I'd love to see it in 4.9.9, but I understand if it does not make the cut off.

[joemcgill]

I've not gotten time to test this one. Going to move to the 5.1 milestone.

[kirasong]

Refresh of patch and spacing.

[kirasong]

Refreshed patch and added some spacing in 44563.2.diff​.

[desrosj]

At a minimum, the tests for `path_is_absolute()` should be updated to account for stream URLs. Additional tests would be great. Streams have been problematic lately.

At a minimum as far as testing is concerned, I'd like to know that the issue is solved in the ​S3 Uploads plugin with the suggested approach.

@joemcgill I think this is a 5.2 or Future Release candidate, but did not want to punt it without your input.

[joemcgill]

@desrosj I agree that this will need to slip to a future release. Going to maintain ownership and hope to get this in a future minor.

[joemcgill]

In 45177:

Media: Fix deletion of files when using stream wrappers.

This fixes a bug introduced in [43392] which breaks file deletion on systems using stream wrappers, due to limitations of realpath().

Props antonypuckey, pfiled.
Fixes #44563.

[SergeyBiryukov]

#46487 was marked as a duplicate.