WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44585, comment 6


Ignore:
Timestamp:
03/15/2019 10:53:25 AM (6 years ago)
Author:
johannadevos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #44585, comment 6

    initial v1  
    1 It seems that while you guys were working on this ticket, a [https://core.trac.wordpress.org/ticket/45204 duplicate ticket] was created. In that ticket (#45204), the first solution as proposed in the current ticket (#44585) was accepted and implemented in WordPress's code base. That solution happened to be identical to the first solution in the current ticket, namely `44585.diff`.
     1It seems that while you guys were working on this ticket, a [https://core.trac.wordpress.org/ticket/45204 duplicate ticket] was created. In that ticket (#45204), a patch was accepted and implemented in WordPress's code base. That patch happened to be identical to the first patch in the current ticket (#44585), namely `44585.diff`.
    22
    3 However, @ocean90 has pointed out that this solution is inadequate. As a result, @mbelchev proposed a second solution (`44585.2.diff`), which is the one that we want.
     3However, @ocean90 has pointed out that this patch is inadequate. As a result, @mbelchev proposed a second patch (`44585.2.diff`), which is the one that we want.
    44
    5 Because the inadequate solution has already been implemented in the WordPress code base in the mean time, the `44585.2.diff` patch no longer applies. Therefore, a new patch should be created to implement @ocean90's solution as applied to the current version of the code base.   
     5Because the inadequate patch has already been implemented in the WordPress code base in the mean time, the `44585.2.diff` patch no longer applies. Therefore, a new patch should be created to implement @ocean90's solution as applied to the current version of the code base.