#44590 closed defect (bug) (fixed)
Remove "// WPCS:" comments
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9.8 | Priority: | low |
Severity: | trivial | Version: | 4.9.6 |
Component: | Privacy | Keywords: | good-first-bug has-patch commit fixed-major |
Focuses: | Cc: |
Description
[42967] introduced some comments saying // WPCS: input var ok.
, which I guess someone's IDE decided to write to the file, instead of displaying in some ephemeral way.
Attachments (1)
Change History (8)
#1
@
7 years ago
- Keywords has-patch commit added; needs-patch removed
- Milestone changed from Future Release to 4.9.8
Awesome, thanks for the patch, @burhandodhy!
This is ready to commit and backport.
#2
@
7 years ago
- Owner set to pento
- Resolution set to fixed
- Status changed from new to closed
In 43465:
#3
@
7 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopen for backport.
This ticket was mentioned in Slack in #core-coding-standards by garyj. View the logs.
7 years ago
#7
@
7 years ago
I suspect these crept in when someone tested the patch against the WPCS WordPress
ruleset before submitting it.
For core patches, the phpcs.xml.dist
ruleset in the WP root directory should be used instead. This custom ruleset is based on the WPCS WordPress-Core
ruleset, which, for on the fly patch CS testing, could in most cases be used interchangably.
The WordPress-Core
ruleset does not contain the sniffs for which these whitelist comments are applicable.
" WPCS: input var ok." Removed