WordPress.org

Make WordPress Core

Opened 17 months ago

Last modified 4 weeks ago

#44592 reviewing enhancement

Add support for required WP and PHP versions to themes

Reported by: flixos90 Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch servehappy early
Focuses: Cc:
PR Number:

Description

As a follow-up to #40934 and accompanying the related meta ticket https://meta.trac.wordpress.org/ticket/3718, themes should be allowed to specify minimum required WordPress / PHP versions.

The scope of this ticket is solely to add support for these two headers to WP_Theme, so that they are parsed correctly. Catching unmet version requirements and preventing theme installations/updates/activations should be part of separate follow-up tickets.

This ticket needs to be tackled in alignment with the above meta ticket, in terms of which names to use for the two new headers.

Attachments (2)

44592.diff (656 bytes) - added by flixos90 17 months ago.
44592.2.patch (665 bytes) - added by afragen 5 weeks ago.
Change to Requires at least

Download all attachments as: .zip

Change History (14)

@flixos90
17 months ago

#1 @flixos90
17 months ago

  • Keywords has-patch added; needs-patch removed

44592.diff adds support for a Requires header (for required WP version) and a Requires PHP header (for required PHP version) to WP_Theme. While we could go with Requires WP, I thought it would make sense to align the names with the names of the plugin headers, so people can remember them easily for both plugins and themes.

Going forward though, let's have the discussion on header names in the meta ticket https://meta.trac.wordpress.org/ticket/3718, and adjust the patch here accordingly as necessary.

This ticket was mentioned in Slack in #core-php by flixos90. View the logs.


17 months ago

This ticket was mentioned in Slack in #core-php by schlessera. View the logs.


17 months ago

#4 @pento
14 months ago

  • Milestone changed from 4.9.9 to WordPress.org

#5 @afragen
7 months ago

  • Keywords servehappy added

#7 @afragen
6 months ago

I think we should use Requires WP as it is more descriptive and aligns well with Requires PHP.

#8 @afragen
6 months ago

Looks like we should be using Requires at least as that is what was committed in r45546

Last edited 6 months ago by afragen (previous) (diff)

#9 @spacedmonkey
6 months ago

  • Component changed from Themes to Site Health

@afragen
5 weeks ago

Change to Requires at least

#10 @afragen
5 weeks ago

  • Keywords early added
  • Milestone changed from WordPress.org to 5.4

Patch updated to use Requires at least.

I'm working on testing themes for WordPress and PHP compatibility. Early commit of this ticket is going to be needed or it will end up being in subsequent patches.

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


5 weeks ago

#12 @SergeyBiryukov
4 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.