WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 9 months ago

Last modified 8 months ago

#44592 closed enhancement (fixed)

Add support for required WP and PHP versions to themes

Reported by: flixos90 Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch servehappy early commit has-dev-note
Focuses: Cc:

Description

As a follow-up to #40934 and accompanying the related meta ticket https://meta.trac.wordpress.org/ticket/3718, themes should be allowed to specify minimum required WordPress / PHP versions.

The scope of this ticket is solely to add support for these two headers to WP_Theme, so that they are parsed correctly. Catching unmet version requirements and preventing theme installations/updates/activations should be part of separate follow-up tickets.

This ticket needs to be tackled in alignment with the above meta ticket, in terms of which names to use for the two new headers.

Attachments (2)

44592.diff (656 bytes) - added by flixos90 2 years ago.
44592.2.patch (665 bytes) - added by afragen 12 months ago.
Change to Requires at least

Download all attachments as: .zip

Change History (20)

@flixos90
2 years ago

#1 @flixos90
2 years ago

  • Keywords has-patch added; needs-patch removed

44592.diff adds support for a Requires header (for required WP version) and a Requires PHP header (for required PHP version) to WP_Theme. While we could go with Requires WP, I thought it would make sense to align the names with the names of the plugin headers, so people can remember them easily for both plugins and themes.

Going forward though, let's have the discussion on header names in the meta ticket https://meta.trac.wordpress.org/ticket/3718, and adjust the patch here accordingly as necessary.

This ticket was mentioned in Slack in #core-php by flixos90. View the logs.


2 years ago

This ticket was mentioned in Slack in #core-php by schlessera. View the logs.


2 years ago

#4 @pento
2 years ago

  • Milestone changed from 4.9.9 to WordPress.org

#5 @afragen
18 months ago

  • Keywords servehappy added

#7 @afragen
17 months ago

I think we should use Requires WP as it is more descriptive and aligns well with Requires PHP.

#8 @afragen
16 months ago

Looks like we should be using Requires at least as that is what was committed in r45546

Last edited 16 months ago by afragen (previous) (diff)

#9 @spacedmonkey
16 months ago

  • Component changed from Themes to Site Health

@afragen
12 months ago

Change to Requires at least

#10 @afragen
12 months ago

  • Keywords early added
  • Milestone changed from WordPress.org to 5.4

Patch updated to use Requires at least.

I'm working on testing themes for WordPress and PHP compatibility. Early commit of this ticket is going to be needed or it will end up being in subsequent patches.

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


12 months ago

#12 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#13 @afragen
10 months ago

  • Keywords commit added

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


10 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


9 months ago

#16 @audrasjb
9 months ago

  • Keywords needs-dev-note added

#17 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47145:

Site Health: Add support for required WordPress and PHP versions to themes.

Follow-up to [45546] for plugins.

Props flixos90, afragen.
Fixes #44592. See #40934, #meta3718.

#18 @audrasjb
8 months ago

  • Keywords has-dev-note added; needs-dev-note removed
Note: See TracTickets for help on using tickets.