#44592 closed enhancement (fixed)
Add support for required WP and PHP versions to themes
Reported by: | flixos90 | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | has-patch servehappy early commit has-dev-note |
Focuses: | Cc: |
Description
As a follow-up to #40934 and accompanying the related meta ticket https://meta.trac.wordpress.org/ticket/3718, themes should be allowed to specify minimum required WordPress / PHP versions.
The scope of this ticket is solely to add support for these two headers to WP_Theme
, so that they are parsed correctly. Catching unmet version requirements and preventing theme installations/updates/activations should be part of separate follow-up tickets.
This ticket needs to be tackled in alignment with the above meta ticket, in terms of which names to use for the two new headers.
Attachments (2)
Change History (20)
This ticket was mentioned in Slack in #core-php by flixos90. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-php by schlessera. View the logs.
6 years ago
#7
@
5 years ago
I think we should use Requires WP
as it is more descriptive and aligns well with Requires PHP
.
#8
@
5 years ago
Looks like we should be using Requires at least
as that is what was committed in r45546
#10
@
5 years ago
- Keywords early added
- Milestone changed from WordPress.org to 5.4
Patch updated to use Requires at least
.
I'm working on testing themes for WordPress and PHP compatibility. Early commit of this ticket is going to be needed or it will end up being in subsequent patches.
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
5 years ago
#18
@
5 years ago
- Keywords has-dev-note added; needs-dev-note removed
This change appears in the miscellaneous changes dev note: https://make.wordpress.org/core/2020/02/26/miscellaneous-developer-focused-changes-in-wordpress-5-4/
44592.diff adds support for a
Requires
header (for required WP version) and aRequires PHP
header (for required PHP version) toWP_Theme
. While we could go withRequires WP
, I thought it would make sense to align the names with the names of the plugin headers, so people can remember them easily for both plugins and themes.Going forward though, let's have the discussion on header names in the meta ticket https://meta.trac.wordpress.org/ticket/3718, and adjust the patch here accordingly as necessary.