unit tests that create tmp files should use sys_get_temp_dir() instead of hardcoding /tmp/

[pbiron]

A few of the existing unit tests contain the equivalent of:

copy( DIR_TESTDATA . '/images/foo.jpg', '/tmp/foo.jpg' );

Folks running the tests on Windows need to create C:\tmp for those tests to succeed.

Instead, unit tests should use the equivalent of:

copy( DIR_TESTDATA . '/images/foo.jpg', sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'foo.jpg' );

[pbiron]

44605.diff fixes all existing tests.

There are a few other occurrences of /tmp in the existing tests, but to the best of my knowledge those other uses don't actually try to create temp files in `/tmp'.

I would appreciate someone testing the patch on a non-Windows box to make sure the affected tests still succeed.

[birgire]

Good catches @pbiron but it looks like this belongs to #39975

Maybe you could refresh the latest patch over there if needed?

[pbiron]

Replying to birgire:

Good catches @pbiron but it looks like this belongs to #39975

Maybe you could refresh the latest patch over there if needed?

All the cases my patch fixes are also fixed in the latest patch on #39975.