Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#44608 closed defect (bug) (fixed)

Incorrect docs for `$meta_type` in `WP_Term_Query`

Reported by: dlh's profile dlh Owned by: boonebgorges's profile boonebgorges
Milestone: 4.9.9 Priority: normal
Severity: normal Version: 4.8
Component: Taxonomy Keywords: has-patch commit
Focuses: docs Cc:

Description

The $meta_type query parameter in WP_Term_Query is documented as Type of object metadata is for (e.g., comment, post, or user).

These docs correspond to the $meta_type parameter in the *_metadata() functions. However, it looks to me like the parameter in WP_Term_Query corresponds to the $type parameter in WP_Meta_Query, which is for MySQL data types. The attached patch would update the docs to borrow the meta-query language instead.

Attachments (1)

44608.diff (1.1 KB) - added by dlh 6 years ago.

Download all attachments as: .zip

Change History (7)

@dlh
6 years ago

#1 @boonebgorges
6 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to boonebgorges
  • Status changed from new to assigned

Good catch. Introduced in [40053].

#2 @boonebgorges
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43559:

Correct param documentation for WP_Term_Query.

The description of $meta_type introduced in [40053] was incorrect.

Props dlh.
Fixes #44608.

#3 @SergeyBiryukov
6 years ago

  • Keywords commit fixed-major added
  • Milestone changed from 5.0 to 4.9.9
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.9.9 consideration.

#4 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43621:

Docs: Correct param documentation for WP_Term_Query.

The description of $meta_type introduced in [40053] was incorrect.

Props dlh.
Merges [43559] to the 4.9 branch.
Fixes #44608.

#5 @pento
5 years ago

  • Keywords fixed-major removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

[43559] can be ported to the 5.0 branch.

#6 @boonebgorges
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43689:

Correct param documentation for WP_Term_Query.

The description of $meta_type introduced in [40053] was incorrect.

Props dlh.
Merges [43559] to the 5.0 branch.
Fixes #44608.

Note: See TracTickets for help on using tickets.