WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#4462 closed defect (bug) (fixed)

previous_posts_link() mangles query string

Reported by: markjaquith Owned by:
Milestone: 2.2.1 Priority: high
Severity: major Version: 2.2
Component: Template Keywords:
Focuses: Cc:

Description

Using previous_posts_link() from http://example.com/?s=test&paged=2 will give you a link of:

http://example.com/?s=test#038;paged=1

next_posts_link() is not afflicted.

We'll want this in 2.2.1 as well.

Change History (7)

#1 @ryan
13 years ago

In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems. Anyhow, that's a different issue.

#2 @rob1n
13 years ago

  • Milestone changed from 2.3 (trunk) to 2.2.1

#3 @markjaquith
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5702]) remove &paged=1 *before* we HTML entitize the link. fixes #4462

#4 @markjaquith
13 years ago

Yeah, my mistake, this only affected 2.2.x

Created #4463 for the bug Ryan noticed.

#5 @markjaquith
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Still not right... missing the question mark.

#6 @markjaquith
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Bugs are like onions, they have layers. This was fixed after all, it just uncovered another issue.

See #4464

#7 @markjaquith
13 years ago

(In [5703]) only strip question marks from the RIGHT side of the query string. fixes #4464. see #4462

Note: See TracTickets for help on using tickets.