Attachment Details modal shouldn't manually construct the edit link

[johnbillion]

In the template for the Attachment Details modal, the URL of the Edit more details link is manually constructed using post.php?post={{ data.id }}&action=edit.

This means the URL may not be correct if the actual attachment editing URL is filtered and changed. The template should use {{ data.editLink }}.

[joemcgill]

@johnbillion Looks right to me.

[johnbillion]

In 43601:

Media: Ensure the "Edit more details" link in the attachment details modal always points to the correct editing URL.

Fixes #44620

[johnbillion]

In 43602:

Media: Ensure the "Edit more details" link in the attachment details modal always points to the correct editing URL.

Fixes #44620

Merges [43601] to the 4.9 branch.

[pento]

[43601] can be ported to 5.0. After 5.0, [43602] needs to be reverted from the
4.9 branch (add fixed-major after the port, and leave the issue open).

[SergeyBiryukov]

In 43718:

Media: Ensure the "Edit more details" link in the attachment details modal always points to the correct editing URL.

Merges [43601] to the 5.0 branch.
Fixes #44620.

[SergeyBiryukov]

Reopening for a revert from the 4.9 branch per comment:7.

[peterwilsoncc]

In 43948:

Media: Revert [43602] from the 4.9 branch.

Reverts changes to the "Edit more details" link in the attachment details modal.

This is out of scope for 4.9.9 and will be re-introduced in 5.0.0.

Fixes #44620.