#44627 closed enhancement (fixed)
minor tweaks to Try Gutenberg callout formatting
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9.8 | Priority: | low |
Severity: | minor | Version: | |
Component: | Administration | Keywords: | has-patch has-screenshots commit |
Focuses: | Cc: |
Description
Related: #44611
When the text of the header in the 2nd or 3rd columns of the callout wraps (e.g., with a translation on a narrow screen)
- the
line-height
seems to high- it currently inherits 2.1 from
.try-gutenberg-panel
- I suggest 1.3, @kjellr suggests 1.4...either works for me
- it currently inherits 2.1 from
- the paragraphs do not vertically align
- while it does not look bad that way, I think it would look better if they did
- I tried but couldn't figure out how to accomplish that
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #core by pbiron. View the logs.
7 years ago
#4
@
7 years ago
CSS coding standards: https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#values
Line height should also be unit-less, unless necessary to be defined as a specific pixel value. This is more than just a style convention, but is worth mentioning here. More information: http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/
#5
@
7 years ago
- Keywords needs-refresh added
Needs a refresh for a unitless value, looks good to me otherwise (see before/after screenshot above).
#10
@
7 years ago
- Owner set to pento
- Resolution set to fixed
- Status changed from new to closed
In 43536:
44627.diff changes the line height.
It isn't really possible to make the paragraphs vertically align, without significantly reworking the HTML.
As 4.9.8 is in RC, patch needs sign off from another committer.