WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 19 months ago

#44627 closed enhancement (fixed)

minor tweaks to Try Gutenberg callout formatting

Reported by: pbiron Owned by: pento
Milestone: 4.9.8 Priority: low
Severity: minor Version:
Component: Administration Keywords: has-patch has-screenshots commit
Focuses: Cc:

Description

Related: #44611

When the text of the header in the 2nd or 3rd columns of the callout wraps (e.g., with a translation on a narrow screen)

  1. the line-height seems to high
    • it currently inherits 2.1 from .try-gutenberg-panel
    • I suggest 1.3, @kjellr suggests 1.4...either works for me
  2. the paragraphs do not vertically align
    • while it does not look bad that way, I think it would look better if they did
    • I tried but couldn't figure out how to accomplish that

Attachments (3)

44627.diff (341 bytes) - added by pento 2 years ago.
44627.png (20.9 KB) - added by SergeyBiryukov 2 years ago.
44627.2.diff (603 bytes) - added by pbiron 2 years ago.
unitless line-height

Download all attachments as: .zip

Change History (14)

@pento
2 years ago

#1 @pento
2 years ago

  • Keywords has-patch added

44627.diff changes the line height.

It isn't really possible to make the paragraphs vertically align, without significantly reworking the HTML.

As 4.9.8 is in RC, patch needs sign off from another committer.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


2 years ago

#3 @afercia
2 years ago

line-height values should be unitless.

#4 @afercia
2 years ago

CSS coding standards: https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#values

Line height should also be unit-less, unless necessary to be defined as a specific pixel value. This is more than just a style convention, but is worth mentioning here. More information: http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/

@SergeyBiryukov
2 years ago

#5 @SergeyBiryukov
2 years ago

  • Keywords needs-refresh added

Needs a refresh for a unitless value, looks good to me otherwise (see before/after screenshot above).

#6 @SergeyBiryukov
2 years ago

  • Keywords has-screenshots added

@pbiron
2 years ago

unitless line-height

#7 @pbiron
2 years ago

  • Keywords needs-refresh removed

#9 @SergeyBiryukov
2 years ago

  • Keywords commit added

#10 @pento
2 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 43536:

Dashboard: Tweak the "Try Gutenberg" subheading line height.

Props pento, pbiron, afercia, SergeyBiryukov.
Fixes #44627.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


19 months ago

Note: See TracTickets for help on using tickets.